From: Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
To: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Arjan van de Ven <arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [cgroup or VFS ?] WARNING: at fs/namespace.c:636 mntput_no_expire+0xac/0xf2()
Date: Thu, 12 Feb 2009 07:07:29 +0000 [thread overview]
Message-ID: <20090212070729.GF28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4993C7C2.4060100-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
On Thu, Feb 12, 2009 at 02:54:58PM +0800, Li Zefan wrote:
> But the following testcase can also trigger the warning:
>
> thread 1:
> for ((; ;))
> {
> mount -t cgroup -o ns xxx cgroup/ > /dev/null 2>&1
> # remove the dirs generated by cgroup_clone()
> rmdir cgroup/[1-9]* > /dev/null 2>&1
> umount cgroup/ > /dev/null 2>&1
> }
>
>
> thread 2:
>
> int foo(void *arg)
> { return 0; }
>
> char *stack[4096];
>
> int main(int argc, char **argv)
> {
> int usec = DEFAULT_USEC;
> while (1) {
> usleep(usec);
> # cgroup_clone() will be called
> clone(foo, stack+4096, CLONE_NEWNS, NULL);
> }
>
> return 0;
> }
Uh-oh... That clone() will do more, actually - it will clone a bunch
of vfsmounts. What happens if you create a separate namespace for the
first thread, so that the second one would not have our vfsmount to
play with?
Alternatively, what if the second thread is doing
mount --bind cgroup foo
umount foo
in a loop?
Another one: does turning the umount in the first thread into umount -l
affect anything?
next prev parent reply other threads:[~2009-02-12 7:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <49617D35.4040805@cn.fujitsu.com>
2009-02-09 8:40 ` [cgroup or VFS ?] WARNING: at fs/namespace.c:636 mntput_no_expire+0xac/0xf2() Andrew Morton
2009-02-09 8:49 ` Li Zefan
2009-02-09 11:03 ` Al Viro
2009-02-09 11:58 ` Al Viro
2009-02-10 5:47 ` Li Zefan
2009-02-09 9:34 ` Al Viro
2009-02-09 11:30 ` Li Zefan
2009-02-12 6:10 ` Li Zefan
2009-02-12 6:24 ` Al Viro
2009-02-12 6:33 ` Li Zefan
2009-02-12 6:54 ` Li Zefan
[not found] ` <4993C7C2.4060100-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-02-12 7:07 ` Al Viro [this message]
2009-02-13 5:09 ` Li Zefan
[not found] ` <4995007D.7040101-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-02-13 5:47 ` Al Viro
2009-02-13 6:12 ` Li Zefan
2009-02-13 6:31 ` Li Zefan
[not found] ` <49950F3D.3030704-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-02-13 6:41 ` Al Viro
2009-02-13 7:18 ` Al Viro
[not found] ` <20090213071816.GK28946-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2009-02-13 7:26 ` Li Zefan
2009-02-16 1:29 ` Li Zefan
2009-02-16 2:38 ` Al Viro
2009-02-16 2:47 ` Li Zefan
2009-02-16 2:57 ` Al Viro
2009-02-09 17:48 ` Dave Hansen
2009-02-09 18:11 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090212070729.GF28946@ZenIV.linux.org.uk \
--to=viro-3bdd1+5odreifsdqtta3olvcufugdwfn@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox