From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
vegard.nossum-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
snakebyte-Mmb7MZpHnFY@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jmorris-JSZrJrUvVKb1P9xLtpHBDw@public.gmane.org,
torvalds-3NddpPZAyC0@public.gmane.org,
containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH] User namespaces: Only put the userns when we unhash the uid
Date: Fri, 13 Feb 2009 15:21:14 +0100 [thread overview]
Message-ID: <20090213142114.GA24047@elte.hu> (raw)
In-Reply-To: <20090213140421.5698.86876.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
* David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> From: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>
> uids in namespaces other than init don't get a sysfs entry.
>
> For those in the init namespace, while we're waiting to remove
> the sysfs entry for the uid the uid is still hashed, and
> alloc_uid() may re-grab that uid without getting a new
> reference to the user_ns, which we've already put in free_user
> before scheduling remove_user_sysfs_dir().
>
> Reported-by: KOSAKI Motohiro <kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> Acked-by: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Tested-by: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
beyond the crashes, this should resolve this slab corruption
regression too:
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12503
Subject : [slab corruption] BUG key_jar: Poison overwritten
Submitter : Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
Date : 2009-01-15 18:16 (25 days old)
References : http://marc.info/?l=linux-kernel&m=123204353425825&w=4
Handled-By : David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Ingo
next prev parent reply other threads:[~2009-02-13 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 14:04 [PATCH] User namespaces: Only put the userns when we unhash the uid David Howells
[not found] ` <20090213140421.5698.86876.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2009-02-13 14:21 ` Ingo Molnar [this message]
2009-02-13 15:48 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090213142114.GA24047@elte.hu \
--to=mingo-x9un+bfzkdi@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jmorris-JSZrJrUvVKb1P9xLtpHBDw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=snakebyte-Mmb7MZpHnFY@public.gmane.org \
--cc=torvalds-3NddpPZAyC0@public.gmane.org \
--cc=vegard.nossum-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox