From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: "David C. Hansen" <haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH 4/6] Deny external checkpoint unless task is frozen
Date: Tue, 17 Mar 2009 10:50:34 -0700 [thread overview]
Message-ID: <20090317175034.GE10796@us.ibm.com> (raw)
In-Reply-To: <20090317174359.GA10796-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Thu, 12 Mar 2009 14:20:02 -0700
Subject: [PATCH 4/6] Deny external checkpoint unless task is frozen
Remove a 'FIXME' and ensure that the tasks we are checkpointing are
frozen unless its a self-checkpoint.
Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
checkpoint/checkpoint.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/checkpoint/checkpoint.c b/checkpoint/checkpoint.c
index dae9b97..c16f30c 100644
--- a/checkpoint/checkpoint.c
+++ b/checkpoint/checkpoint.c
@@ -19,6 +19,7 @@
#include <linux/mount.h>
#include <linux/utsname.h>
#include <linux/magic.h>
+#include <linux/freezer.h>
#include <linux/checkpoint.h>
#include <linux/checkpoint_hdr.h>
@@ -275,7 +276,9 @@ static int cr_may_checkpoint_task(struct task_struct *t, struct cr_ctx *ctx)
if (!ptrace_may_access(t, PTRACE_MODE_READ))
return -EPERM;
- /* FIXME: verify that the task is frozen (unless self) */
+ /* verify that the task is frozen (unless self) */
+ if (t != current && !frozen(t))
+ return -EBUSY;
/* FIXME: change this for nested containers */
if (task_nsproxy(t) != ctx->root_nsproxy)
--
1.5.2.5
next prev parent reply other threads:[~2009-03-17 17:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 17:43 [PATCH 0/6] /proc/pid/checkpointable Sukadev Bhattiprolu
[not found] ` <20090317174359.GA10796-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-17 17:49 ` [PATCH 1/6] Checkpoint multiple processes Sukadev Bhattiprolu
2009-03-17 17:49 ` [PATCH 2/6] Restart " Sukadev Bhattiprolu
2009-03-17 17:50 ` [PATCH 3/6] Check 'may_checkpoint()' early Sukadev Bhattiprolu
[not found] ` <20090317175013.GD10796-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-26 5:58 ` Sukadev Bhattiprolu
[not found] ` <20090326055840.GA8220-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-26 13:25 ` Serge E. Hallyn
2009-03-17 17:50 ` Sukadev Bhattiprolu [this message]
2009-03-17 17:51 ` [PATCH 5/6] Define and use proc_pid_checkpointable() Sukadev Bhattiprolu
2009-03-17 17:51 ` [PATCH 6/6] Explain reason for task being uncheckpointable Sukadev Bhattiprolu
[not found] ` <20090317175149.GG10796-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-17 18:52 ` Serge E. Hallyn
[not found] ` <20090317185228.GC1039-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-18 6:50 ` Sukadev Bhattiprolu
2009-03-18 9:28 ` [PATCH 0/6] /proc/pid/checkpointable Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090317175034.GE10796@us.ibm.com \
--to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox