Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [PATCH] c/r: Take uts_sem during checkpoint and restart
Date: Thu, 16 Apr 2009 11:51:54 -0500	[thread overview]
Message-ID: <20090416165154.GD20736@us.ibm.com> (raw)
In-Reply-To: <87bpqwa6ku.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>

Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> SH> At checkpoint, you only need the uts_sem right around the reading
> SH> (and length-checking) of uts_ns->name.  You're keeping it around
> SH> writing into the checkpoint image (and cr_hbuf_get).
> 
> Right, okay.
> 
> SH> At restart, you shouldn't actually need uts_sem - the nsproxy is
> SH> not yet available to anyone else, so there is no chance of a race,
> SH> right?  Hmm, well maybe I'm being overly optimistic, since restart
> SH> is coordinated by userspace which could mess up and somehow run
> SH> sethostname(2) while it's supposed to be running sys_restart().
> SH> But then sys_restart() wouldn't yet have hooked up the task to the
> SH> new nsproxy.
> 
> Good, you passed the test.  Yeah, that's it... :)

woohoo

-serge

      parent reply	other threads:[~2009-04-16 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 15:59 [PATCH] c/r: Take uts_sem during checkpoint and restart Dan Smith
     [not found] ` <1239897585-19246-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-04-16 16:33   ` Serge E. Hallyn
2009-04-16 16:47     ` Dan Smith
     [not found]       ` <87bpqwa6ku.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-04-16 16:51         ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090416165154.GD20736@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox