Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH 1/1] mktree: long is bigger on 64-bit
Date: Tue, 12 May 2009 22:08:30 -0500	[thread overview]
Message-ID: <20090513030830.GA11265@us.ibm.com> (raw)

mktree's hash function assumes that long is 32 bits.  Fix.

Signed-off-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
 mktree.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/mktree.c b/mktree.c
index 7a8cecc..0195974 100644
--- a/mktree.c
+++ b/mktree.c
@@ -724,6 +724,7 @@ static int ckpt_make_tree(struct ckpt_ctx *ctx, struct task *task)
 	struct task *child;
 	struct pid_swap swap;
 	pid_t newpid;
+	int status;
 	int ret;
 
 	ckpt_dbg("pid %d: pid %d sid %d parent %d\n",
@@ -765,7 +766,7 @@ static int ckpt_make_tree(struct ckpt_ctx *ctx, struct task *task)
 	/* 3rd pass: bring out your deads ... */
 	for (child = task->children; child; child = child->next_sib) {
 		if (child->flags & TASK_DEAD) {
-			ret = waitpid(child->rpid, NULL, 0);
+			ret = waitpid(child->rpid, &status, 0);
 			if (ret < 0) {
 				perror("waitpid");
 				return -1;
@@ -1291,7 +1292,8 @@ static void hash_exit(struct ckpt_ctx *ctx)
 static inline int hash_func(long key)
 {
 	unsigned long hash = key * GOLDEN_RATIO_PRIME_32;
-	return (hash >> (32 - HASH_BITS));
+	//return (hash >> (32 - HASH_BITS));
+	return (hash >> (sizeof(long)*8 - HASH_BITS));
 }
 
 static int hash_insert(struct ckpt_ctx *ctx, long key, void *data)
-- 
1.6.1.1

             reply	other threads:[~2009-05-13  3:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13  3:08 Serge E. Hallyn [this message]
     [not found] ` <20090513030830.GA11265-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-13  4:48   ` [PATCH 1/1] mktree: long is bigger on 64-bit Matt Helsley
     [not found]     ` <20090513044853.GH3912-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-13 12:57       ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090513030830.GA11265@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox