From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"David C. Hansen"
<haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 7/7] [PATCH] Define clone_with_pids syscall
Date: Wed, 27 May 2009 19:58:29 -0700 [thread overview]
Message-ID: <20090528025829.GA14605@us.ibm.com> (raw)
In-Reply-To: <4A1D9A47.6030201-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
| > + if (copy_from_user(&pid_set, upid_setp, sizeof(pid_set)))
| > + return ERR_PTR(-EFAULT);
| > +
| > + size = pid_set.num_pids * sizeof(pid_t);
|
| ...either test "pid_set.num_pids > 0" (and give -EINVAL),
| or...
Good point. I now check for num_pids > 0 and treat num_pids == 0 as
normal clone().
While addressing this I realized I had a lot of arch-independent code
in arch/x86/kernel/process_32.c. I have now moved this common code to
kernel/fork.c. Its non-trivial code move, so need new review/acks from
you and Serge for at least patches 6 and 7.
Sukadev
next prev parent reply other threads:[~2009-05-28 2:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 15:42 [PATCH 1/7] [PATCH] Factor out code to allocate pidmap page Sukadev Bhattiprolu
[not found] ` <20090527154212.GA3107-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-27 15:42 ` [PATCH 2/7] [PATCH] Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
[not found] ` <20090527154259.GB3107-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-27 17:27 ` Dave Hansen
2009-05-27 17:43 ` Serge E. Hallyn
2009-05-27 19:37 ` Oren Laadan
2009-05-27 15:43 ` [PATCH 3/7] [PATCH] Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
[not found] ` <20090527154333.GC3107-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-27 17:56 ` Serge E. Hallyn
2009-05-27 15:43 ` [PATCH 4/7] [PATCH] Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
[not found] ` <20090527154355.GD3107-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-27 18:05 ` Serge E. Hallyn
2009-05-27 15:44 ` [PATCH 5/7] [PATCH] Add target_pids parameter to copy_process() Sukadev Bhattiprolu
[not found] ` <20090527154422.GE3107-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-27 18:05 ` Serge E. Hallyn
2009-05-27 19:41 ` Oren Laadan
2009-05-27 15:44 ` [PATCH 6/7] [PATCH] Define do_fork_with_pids() Sukadev Bhattiprolu
[not found] ` <20090527154443.GF3107-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-27 18:05 ` Serge E. Hallyn
2009-05-27 19:40 ` Oren Laadan
2009-05-27 15:45 ` [PATCH 7/7] [PATCH] Define clone_with_pids syscall Sukadev Bhattiprolu
[not found] ` <20090527154507.GG3107-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-27 18:19 ` Serge E. Hallyn
2009-05-27 19:53 ` Oren Laadan
[not found] ` <4A1D9A47.6030201-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-05-28 2:58 ` Sukadev Bhattiprolu [this message]
2009-05-27 17:26 ` [PATCH 1/7] [PATCH] Factor out code to allocate pidmap page Dave Hansen
2009-05-27 17:48 ` Serge E. Hallyn
2009-05-27 19:31 ` Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528025829.GA14605@us.ibm.com \
--to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox