Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	Linux Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [patch 100/148] cgroups: convert tasks file to use a seq_file with shared pid array
Date: Wed, 17 Jun 2009 08:52:16 -0500	[thread overview]
Message-ID: <20090617135216.GC18056@us.ibm.com> (raw)
In-Reply-To: <6599ad830906162146n5a79b9b8n3b7dd0e72c72ab7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Quoting Paul Menage (menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org):
> It just struck me that this patch broke access to the tasks file in
> the presence of multiple pid namespaces, since the pids in the cached

Hmm, sure does.

> pid array are always from the namespace of the last process to open
> the file.

Well it's only around as long as the file is open, so I guess that's
another reason noone has hit this bug.  A task in pidns B must
open the file between the open and close by a task in pidns A.

> Since I suspect no-one uses pid namespaces in production
> environments this probably isn't a show-stopper, but to be technically
> correct we need to maintain a list of cached pid arrays keyed by pid
> namespace. (This list should generally be very short, usually of
> length 1).

Just to clarify - do you have a patch in the works for this, or are you
asking for the patch to be written?

thanks,
-serge

  parent reply	other threads:[~2009-06-17 13:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200810190328.m9J3S4aB000311@imap1.linux-foundation.org>
     [not found] ` <200810190328.m9J3S4aB000311-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2009-06-17  4:46   ` [patch 100/148] cgroups: convert tasks file to use a seq_file with shared pid array Paul Menage
     [not found]     ` <6599ad830906162146n5a79b9b8n3b7dd0e72c72ab7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-06-17 13:52       ` Serge E. Hallyn [this message]
     [not found]         ` <20090617135216.GC18056-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-17 15:18           ` Paul Menage
2009-06-18  1:41       ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090617135216.GC18056@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox