Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH 1/1] cr: uts: don't pass an unsigned var as a signed int
Date: Fri, 19 Jun 2009 15:37:19 -0500	[thread overview]
Message-ID: <20090619203719.GA30093@us.ibm.com> (raw)

Else my checkpoing image gets reeeaallly huge.  Just passing the
result of sizeof() however does the right thing.

Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
 checkpoint/namespace.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/checkpoint/namespace.c b/checkpoint/namespace.c
index 5726acb..8206aee 100644
--- a/checkpoint/namespace.c
+++ b/checkpoint/namespace.c
@@ -46,22 +46,22 @@ static int do_checkpoint_uts_ns(struct ckpt_ctx *ctx,
 		return ret;
 
 	down_read(&uts_sem);
-	ret = ckpt_write_string(ctx, name->sysname, h->sysname_len);
+	ret = ckpt_write_string(ctx, name->sysname, sizeof(name->sysname));
 	if (ret < 0)
 		goto up;
-	ret = ckpt_write_string(ctx, name->nodename, h->nodename_len);
+	ret = ckpt_write_string(ctx, name->nodename, sizeof(name->nodename));
 	if (ret < 0)
 		goto up;
-	ret = ckpt_write_string(ctx, name->release, h->release_len);
+	ret = ckpt_write_string(ctx, name->release, sizeof(name->release));
 	if (ret < 0)
 		goto up;
-	ret = ckpt_write_string(ctx, name->version, h->version_len);
+	ret = ckpt_write_string(ctx, name->version, sizeof(name->version));
 	if (ret < 0)
 		goto up;
-	ret = ckpt_write_string(ctx, name->machine, h->machine_len);
+	ret = ckpt_write_string(ctx, name->machine, sizeof(name->machine));
 	if (ret < 0)
 		goto up;
-	ret = ckpt_write_string(ctx, name->domainname, h->domainname_len);
+	ret = ckpt_write_string(ctx, name->domainname, sizeof(name->domainname));
  up:
 	up_read(&uts_sem);
 	return ret;
-- 
1.6.1

             reply	other threads:[~2009-06-19 20:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19 20:37 Serge E. Hallyn [this message]
     [not found] ` <20090619203719.GA30093-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-20  4:27   ` [PATCH 1/1] cr: uts: don't pass an unsigned var as a signed int Nathan Lynch
     [not found]     ` <m3prczfs2m.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-06-21  0:18       ` Serge E. Hallyn
     [not found]         ` <20090621001837.GA32394-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2009-06-21  5:29           ` Nathan Lynch
     [not found]             ` <m34ouaf942.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-06-21 13:53               ` Serge E. Hallyn
2009-06-21 19:13               ` Serge E. Hallyn
     [not found]                 ` <20090621191305.GA2499-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2009-06-22  4:13                   ` Nathan Lynch
     [not found]                     ` <m3fxdsc3dm.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-06-24 17:07                       ` Oren Laadan
2009-06-23 11:41                   ` Cedric Le Goater
     [not found]                     ` <4A40BF4F.9080704-GANU6spQydw@public.gmane.org>
2009-06-23 13:05                       ` Serge E. Hallyn
2009-06-22 23:20   ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090619203719.GA30093@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox