From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Nathan T Lynch <natlynch-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH 1/1] cr: uts: don't deref h after freeing
Date: Tue, 23 Jun 2009 14:37:02 -0500 [thread overview]
Message-ID: <20090623193702.GA25291@us.ibm.com> (raw)
Don't pass h->xyz_len etc as lengths after freeing h! Send
the result of sizeof(name->xyz) directly.
Changelog: Jun 23: resend with new description which accurately
describes what is being fixed (figured out by Nathan Lynch).
Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
checkpoint/namespace.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/checkpoint/namespace.c b/checkpoint/namespace.c
index 5726acb..8206aee 100644
--- a/checkpoint/namespace.c
+++ b/checkpoint/namespace.c
@@ -46,22 +46,22 @@ static int do_checkpoint_uts_ns(struct ckpt_ctx *ctx,
return ret;
down_read(&uts_sem);
- ret = ckpt_write_string(ctx, name->sysname, h->sysname_len);
+ ret = ckpt_write_string(ctx, name->sysname, sizeof(name->sysname));
if (ret < 0)
goto up;
- ret = ckpt_write_string(ctx, name->nodename, h->nodename_len);
+ ret = ckpt_write_string(ctx, name->nodename, sizeof(name->nodename));
if (ret < 0)
goto up;
- ret = ckpt_write_string(ctx, name->release, h->release_len);
+ ret = ckpt_write_string(ctx, name->release, sizeof(name->release));
if (ret < 0)
goto up;
- ret = ckpt_write_string(ctx, name->version, h->version_len);
+ ret = ckpt_write_string(ctx, name->version, sizeof(name->version));
if (ret < 0)
goto up;
- ret = ckpt_write_string(ctx, name->machine, h->machine_len);
+ ret = ckpt_write_string(ctx, name->machine, sizeof(name->machine));
if (ret < 0)
goto up;
- ret = ckpt_write_string(ctx, name->domainname, h->domainname_len);
+ ret = ckpt_write_string(ctx, name->domainname, sizeof(name->domainname));
up:
up_read(&uts_sem);
return ret;
--
1.6.1
next reply other threads:[~2009-06-23 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 19:37 Serge E. Hallyn [this message]
[not found] ` <20090623193702.GA25291-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-24 16:54 ` [PATCH 1/1] cr: uts: don't deref h after freeing Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623193702.GA25291@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=natlynch-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox