From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 1/1] cr: define CKPT_ARCH_NSIG for s390x Date: Fri, 26 Jun 2009 07:33:16 -0500 Message-ID: <20090626123316.GB14049@us.ibm.com> References: <20090625184847.GA11510@us.ibm.com> <4A442D84.5010009@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4A442D84.5010009-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: Linux Containers List-Id: containers.vger.kernel.org Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): > > > Serge E. Hallyn wrote: > > Else compilation fails on s390x. > > > > Signed-off-by: Serge E. Hallyn > > --- > > arch/s390/include/asm/checkpoint_hdr.h | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/arch/s390/include/asm/checkpoint_hdr.h b/arch/s390/include/asm/checkpoint_hdr.h > > index fc0ace8..a5aaa3e 100644 > > --- a/arch/s390/include/asm/checkpoint_hdr.h > > +++ b/arch/s390/include/asm/checkpoint_hdr.h > > @@ -79,6 +79,8 @@ struct ckpt_hdr_mm_context { > > unsigned long asce_limit; > > }; > > > > +#define CKPT_ARCH_NSIG _SIGCONTEXT_NSIG > > + > > But _SIGCONTEXT_NSIG is defined within #ifdef __KERNEL__ ? hmm? hmm. right, indirectly, failed to notice that... Well I don't really like to just hard define it to 64 especially without leaving a note at the sigcontext.h NSIG defines... Should we define both it and the x86 version in not under #ifdef __KERNEL__? -serge