Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH 1/1] cr: move CKPT_ARCH_NSIG to asm/signal.h
Date: Fri, 26 Jun 2009 10:30:12 -0500	[thread overview]
Message-ID: <20090626153012.GA23103@us.ibm.com> (raw)

I dunno...  does this seem worth a shot?  Or should I just go ahead
and #define CKPT_ARCH_NSIG in arch/s390/include/asm/checkpoint_hdr.h
after all?

From c128ce9ebc0bea5801f90ba99a58fcc18b7df84f Mon Sep 17 00:00:00 2001
From: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Date: Fri, 26 Jun 2009 10:59:17 -0400
Subject: [PATCH 1/1] cr: move CKPT_ARCH_NSIG to asm/signal.h

Just a thought...  if the signal code changes we don't want
the checkpoint code getting out of sync.  But putting it where
it really belongs - asm/sigcontext.h - doesn't work bc that's
under ifdef __KERNEL__.  So does this seem like a reasonable thing
to do?

Also define the value for s390.

Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
 arch/s390/include/asm/signal.h        |    2 ++
 arch/x86/include/asm/checkpoint_hdr.h |    2 --
 arch/x86/include/asm/signal.h         |    1 +
 include/linux/checkpoint_hdr.h        |    1 +
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/s390/include/asm/signal.h b/arch/s390/include/asm/signal.h
index f6cfddb..bcd7afa 100644
--- a/arch/s390/include/asm/signal.h
+++ b/arch/s390/include/asm/signal.h
@@ -38,6 +38,8 @@ typedef unsigned long sigset_t;
 
 #endif /* __KERNEL__ */
 
+#define CKPT_ARCH_NSIG	64
+
 #define SIGHUP           1
 #define SIGINT           2
 #define SIGQUIT          3
diff --git a/arch/x86/include/asm/checkpoint_hdr.h b/arch/x86/include/asm/checkpoint_hdr.h
index 745038b..16485ca 100644
--- a/arch/x86/include/asm/checkpoint_hdr.h
+++ b/arch/x86/include/asm/checkpoint_hdr.h
@@ -44,8 +44,6 @@ enum {
 	CKPT_HDR_MM_CONTEXT_LDT,
 };
 
-#define CKPT_ARCH_NSIG  64
-
 struct ckpt_hdr_header_arch {
 	struct ckpt_hdr h;
 	/* FIXME: add HAVE_HWFP */
diff --git a/arch/x86/include/asm/signal.h b/arch/x86/include/asm/signal.h
index 7761a5d..de9147d 100644
--- a/arch/x86/include/asm/signal.h
+++ b/arch/x86/include/asm/signal.h
@@ -40,6 +40,7 @@ typedef unsigned long sigset_t;
 #endif /* __KERNEL__ */
 #endif /* __ASSEMBLY__ */
 
+#define CKPT_ARCH_NSIG  64
 #define SIGHUP		 1
 #define SIGINT		 2
 #define SIGQUIT		 3
diff --git a/include/linux/checkpoint_hdr.h b/include/linux/checkpoint_hdr.h
index 37bae3d..7d16664 100644
--- a/include/linux/checkpoint_hdr.h
+++ b/include/linux/checkpoint_hdr.h
@@ -12,6 +12,7 @@
 
 #include <linux/types.h>
 #include <linux/utsname.h>
+#include <asm/signal.h> /* for CKPT_ARCH_NSIG */
 
 /*
  * To maintain compatibility between 32-bit and 64-bit architecture flavors,
-- 
1.6.1

             reply	other threads:[~2009-06-26 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-26 15:30 Serge E. Hallyn [this message]
     [not found] ` <20090626153012.GA23103-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-26 16:02   ` [PATCH 1/1] cr: move CKPT_ARCH_NSIG to asm/signal.h Oren Laadan
     [not found]     ` <4A44F11B.20803-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-06-26 16:27       ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090626153012.GA23103@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox