From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: [RFC][PATCH] Deny CLONE_PARENT|CLONE_NEWPID|CLONE_SIGHAND combination Date: Wed, 1 Jul 2009 00:40:45 -0700 Message-ID: <20090701074045.GA14595@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, "Eric W. Biederman" , Oren Laadan Cc: Containers , Alexey Dobriyan , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org Deny CLONE_PARENT|CLONE_NEWPID|CLONE_SIGHAND combination. CLONE_PARENT was used to implement an older threading model. For consistency with the CLONE_THREAD check in copy_pid_ns(), disable CLONE_PARENT and CLONE_SIGHAND with CLONE_NEWPID, at least until the required semantics of the pid namespaces are clear. Changelog[v2]: [Eric Biederman] Disable CLONE_SIGHAND also ??? Signed-off-by: Sukadev Bhattiprolu Acked-by: Roland McGrath --- kernel/pid_namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-mmotm/kernel/pid_namespace.c =================================================================== --- linux-mmotm.orig/kernel/pid_namespace.c 2009-06-30 23:01:09.000000000 -0700 +++ linux-mmotm/kernel/pid_namespace.c 2009-06-30 23:49:06.000000000 -0700 @@ -118,7 +118,7 @@ struct pid_namespace *copy_pid_ns(unsign { if (!(flags & CLONE_NEWPID)) return get_pid_ns(old_ns); - if (flags & CLONE_THREAD) + if (flags & (CLONE_THREAD|CLONE_PARENT|CLONE_SIGHAND)) return ERR_PTR(-EINVAL); return create_pid_namespace(old_ns); }