From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [PATCH 4/4] cr_tests: Use stdout for rewrite-cr-header.sh output
Date: Wed, 5 Aug 2009 09:02:57 -0500 [thread overview]
Message-ID: <20090805140257.GC31272@us.ibm.com> (raw)
In-Reply-To: <1249447347-26415-4-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Quoting Matt Helsley (matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> Instead of overwriting cr.h in the current directory write the output
> of rewrite-cr-header.sh to stdout and let whoever invokes the script
> decide what to do with the output. This should make it slightly
> easier to test and make the script more widely usable (e.g. in user-cr).
>
> Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> Cc: Linux Containers <containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
All applied, thanks.
-serge
> ---
> rewrite-cr-header.sh | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/rewrite-cr-header.sh b/rewrite-cr-header.sh
> index ffc6f62..97f39fc 100755
> --- a/rewrite-cr-header.sh
> +++ b/rewrite-cr-header.sh
> @@ -40,9 +40,6 @@ fi
>
> ################################################################################
>
> -mv cr.h cr.h.bak || exit -1
> -
> -(
> COND='#if'
> set -e
> echo '/* AUTOMATICALLY GENERATED by rewrite-cr-header.sh */'
> @@ -88,9 +85,3 @@ while read UNISTDH ; do
> COND='#elif'
> done
> echo -e '#else\n#error "Architecture does not have definitons for __NR_(checkpoint|restart)"\n#endif'
> -) > cr.h || {
> - mv -f cr.h.bak cr.h
> - exit -1
> -}
> -
> -rm -f cr.h.bak
> --
> 1.5.6.3
prev parent reply other threads:[~2009-08-05 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 4:42 [PATCH 4/4] cr_tests: Use stdout for rewrite-cr-header.sh output Matt Helsley
[not found] ` <1249447347-26415-4-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-08-05 14:02 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805140257.GC31272@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox