From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH 1/1] signal c/r: don't play with zero timeouts
Date: Thu, 27 Aug 2009 13:49:34 -0500 [thread overview]
Message-ID: <20090827184934.GA20580@us.ibm.com> (raw)
If it_virt_expires or it_prof_expires is zero, then don't
subtract {virt,prof}_ticks(t) from it. This is the same
thing do_getitimer() does, and it fixes my issues with
the signals c/r patchset on s390.
Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
checkpoint/signal.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/checkpoint/signal.c b/checkpoint/signal.c
index 960356c..15b7cdc 100644
--- a/checkpoint/signal.c
+++ b/checkpoint/signal.c
@@ -382,13 +382,17 @@ static int checkpoint_signal(struct ckpt_ctx *ctx, struct task_struct *t)
}
h->it_real_incr = ktime_to_ns(signal->it_real_incr);
- cputime = cputime_sub(signal->it_virt_expires, virt_ticks(t));
+ cputime = signal->it_virt_expires;
+ if (!cputime_eq(cputime, cputime_zero))
+ cputime = cputime_sub(signal->it_virt_expires, virt_ticks(t));
cputime_to_timeval(cputime, &tval);
h->it_virt_value = timeval_to_ns(&tval);
cputime_to_timeval(signal->it_virt_incr, &tval);
h->it_virt_incr = timeval_to_ns(&tval);
- cputime = cputime_sub(signal->it_prof_expires, prof_ticks(t));
+ cputime = signal->it_prof_expires;
+ if (!cputime_eq(cputime, cputime_zero))
+ cputime = cputime_sub(signal->it_prof_expires, prof_ticks(t));
cputime_to_timeval(cputime, &tval);
h->it_prof_value = timeval_to_ns(&tval);
cputime_to_timeval(signal->it_prof_incr, &tval);
--
1.6.1
next reply other threads:[~2009-08-27 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 18:49 Serge E. Hallyn [this message]
[not found] ` <20090827184934.GA20580-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-08-28 15:21 ` [PATCH 1/1] signal c/r: don't play with zero timeouts Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090827184934.GA20580@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox