Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 1/1] cr: add a few more ckpt_write_err()s
Date: Mon, 14 Sep 2009 08:24:44 -0500	[thread overview]
Message-ID: <20090914132444.GA5379@us.ibm.com> (raw)
In-Reply-To: <4AAE3B47.9020106-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>

Quoting Oren Laadan (orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org):
> 
> Serge E. Hallyn wrote:
> > 
> > Yes, it'd be useful.  BTW it also would be useful to have mktree/
> > restart auto-detect such error strings and report them.
> > 
> 
> 'ckptinfo -e' should already do this, but sure, we can add a switch

Oh, ha, I wouldn't know, bc ckptinfo has never compiled for me, and
I'd never yet cared to beat it into compiling.

Looks like it will work for me if I do

	export KERNELHDR=/usr/include

in my shell before compiling, and use the following patch:

diff --git a/Makefile b/Makefile
index afff3f5..f7bd93b 100644
--- a/Makefile
+++ b/Makefile
@@ -48,7 +48,7 @@ mktree:       CFLAGS += -D__REENTRANT -pthread
 
ckptinfo_types.o: ckptinfo_types.c
	@echo $(CC) -c $(CFLAGS) $<
-	@$(CC) -c $(CFLAGS) $<
+	@$(CC) -D__GLIBC__=2 -c $(CFLAGS) $<
 
 ckptinfo_types.c: $(CKPT_HEADERS) ckptinfo.py
	@echo cat $(CKPT_HEADERS) | ./ckptinfo.py > ckptinfo_types.c


> to 'restart' to check it too. An dyes, in the kernel definitely.
> 
> Oren.

      parent reply	other threads:[~2009-09-14 13:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10 22:33 [PATCH 1/1] cr: add a few more ckpt_write_err()s Serge E. Hallyn
     [not found] ` <20090910223344.GA11718-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-11 21:15   ` Oren Laadan
     [not found]     ` <4AAABE01.1080807-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-11 21:27       ` Serge E. Hallyn
     [not found]         ` <20090911212742.GB15329-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-14 12:47           ` Oren Laadan
     [not found]             ` <4AAE3B47.9020106-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-14 13:24               ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090914132444.GA5379@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox