From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH 1/4] debug: add a few ckpt_debugs
Date: Mon, 5 Oct 2009 16:51:14 -0500 [thread overview]
Message-ID: <20091005215114.GA26052@us.ibm.com> (raw)
These were pulled out of the lsm-related patches into which they
had been embedded.
Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
checkpoint/files.c | 3 +++
checkpoint/process.c | 20 ++++++++++++++++----
kernel/cred.c | 2 ++
3 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/checkpoint/files.c b/checkpoint/files.c
index 27e29a0..f6de07e 100644
--- a/checkpoint/files.c
+++ b/checkpoint/files.c
@@ -159,6 +159,9 @@ int checkpoint_file_common(struct ckpt_ctx *ctx, struct file *file,
if (h->f_credref < 0)
return h->f_credref;
+ ckpt_debug("file %s credref %d", file->f_dentry->d_name.name,
+ h->f_credref);
+
/* FIX: need also file->f_owner, etc */
return 0;
diff --git a/checkpoint/process.c b/checkpoint/process.c
index 424f688..8a7459d 100644
--- a/checkpoint/process.c
+++ b/checkpoint/process.c
@@ -581,11 +581,15 @@ static int restore_task_creds(struct ckpt_ctx *ctx)
realcred = ckpt_obj_fetch(ctx, h->cred_ref, CKPT_OBJ_CRED);
if (IS_ERR(realcred)) {
+ ckpt_debug("Error %ld fetching realcred (ref %d)\n",
+ PTR_ERR(realcred), h->cred_ref);
ret = PTR_ERR(realcred);
goto out;
}
ecred = ckpt_obj_fetch(ctx, h->ecred_ref, CKPT_OBJ_CRED);
if (IS_ERR(ecred)) {
+ ckpt_debug("Error %ld fetching ecred (ref %d)\n",
+ PTR_ERR(ecred), h->ecred_ref);
ret = PTR_ERR(ecred);
goto out;
}
@@ -593,6 +597,7 @@ static int restore_task_creds(struct ckpt_ctx *ctx)
ctx->ecred = ecred;
out:
+ ckpt_debug("Returning %d\n", ret);
ckpt_hdr_put(ctx, h);
return ret;
}
@@ -608,14 +613,21 @@ static int restore_task_objs(struct ckpt_ctx *ctx)
* referenced. See comment in checkpoint_task_objs.
*/
ret = restore_task_creds(ctx);
- if (!ret)
- ret = restore_task_ns(ctx);
- if (ret < 0)
+ if (ret < 0) {
+ ckpt_debug("restore_task_creds returned %d\n", ret);
+ return ret;
+ }
+ ret = restore_task_ns(ctx);
+ if (ret < 0) {
+ ckpt_debug("restore_task_ns returned %d\n", ret);
return ret;
+ }
h = ckpt_read_obj_type(ctx, sizeof(*h), CKPT_HDR_TASK_OBJS);
- if (IS_ERR(h))
+ if (IS_ERR(h)) {
+ ckpt_debug("Error fetching task obj\n");
return PTR_ERR(h);
+ }
ret = restore_obj_file_table(ctx, h->files_objref);
ckpt_debug("file_table: ret %d (%p)\n", ret, current->files);
diff --git a/kernel/cred.c b/kernel/cred.c
index 9710cae..62d28a4 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -724,6 +724,8 @@ static int do_checkpoint_cred(struct ckpt_ctx *ctx, struct cred *cred)
if (!h)
return -ENOMEM;
+ ckpt_debug("cred uid %d fsuid %d gid %d\n", cred->uid, cred->fsuid,
+ cred->gid);
h->uid = cred->uid;
h->suid = cred->suid;
h->euid = cred->euid;
--
1.6.1
next reply other threads:[~2009-10-05 21:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 21:51 Serge E. Hallyn [this message]
[not found] ` <20091005215114.GA26052-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-05 21:53 ` [PATCH 2/4] cr: add generic LSM c/r support (v4) Serge E. Hallyn
2009-10-05 21:54 ` [PATCH 3/4] cr: add smack support to lsm c/r (v4) Serge E. Hallyn
[not found] ` <20091005215410.GB26081-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-09 4:18 ` Casey Schaufler
2009-10-05 21:56 ` [PATCH 4/4] cr: add selinux support (v5.1) Serge E. Hallyn
2009-10-05 21:58 ` [PATCH 1/1] restart: accept the lsm_name field in header and add -k flag (v2) Serge E. Hallyn
-- strict thread matches above, loose matches on Subject: below --
2009-10-09 20:55 [PATCH 1/4] debug: add a few ckpt_debugs Serge E. Hallyn
[not found] ` <20091009205552.GA5778-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-14 22:41 ` Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005215114.GA26052@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox