From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 1/2] Add socket list helper functions Date: Tue, 13 Oct 2009 10:34:50 -0500 Message-ID: <20091013153450.GB10447@us.ibm.com> References: <1254932945-12578-1-git-send-email-danms@us.ibm.com> <1254932945-12578-2-git-send-email-danms@us.ibm.com> <4AD39F37.2000007@librato.com> <87d44re36u.fsf@caffeine.danplanet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87d44re36u.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Smith Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > OL> IMHO this is over-engineered. This way, you place net-related > OL> knowledge in ckpt_ctx_free(), instead of isolating that sort of > OL> smarts under net/ subdir. I'd rather see the clean-up logic near > OL> the "litter" logic, so to speak. > > Well, I still need to clean up the list after the deferqueue has run, > so something has to go into ckpt_ctx_free() to do that. I can make it > a specific call like ckpt_sock_cleanup_listening() or something, but > that will still need to go in checkpoint.h so I can call it from > ctx_free()... Heh, but that sounds like over-engineering :) -serge