From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [RFC PATCH 02/17] make ckpt_format_fmt non-static in checkpoint/sys.c
Date: Wed, 28 Oct 2009 13:31:20 -0500 [thread overview]
Message-ID: <20091028183120.GA22902@us.ibm.com> (raw)
In-Reply-To: <20091028180418.GB19554-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Quoting Serge E. Hallyn (serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> Quoting Matt Helsley (matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> > On Tue, Oct 27, 2009 at 05:46:12PM -0500, Serge Hallyn wrote:
> > > From: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> > >
> > > Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> >
> > nit: Would be nice to see a brief description along the lines
> > "Heads up: here's why I'm moving this and making it non-static"
>
> Crap - i wrote one, but it must have gotten lost in one of
> my several rebases.
Can't find it. For now, the reason is:
We will use ckpt_format_fmt in ckpt_error() which is used
(and far more useful) in restart as well. So move it out
of checkpoint.c and into sys.c.
next prev parent reply other threads:[~2009-10-28 18:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 22:46 [RFC PATCH 0/17] Introduce ckpt_error Serge Hallyn
[not found] ` <1256683587-23961-1-git-send-email-serge-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-27 22:46 ` [RFC PATCH 01/17] ckpt_write_err: use single format with %(T) style tokens Serge Hallyn
[not found] ` <1256683587-23961-2-git-send-email-serge-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-28 16:50 ` Matt Helsley
2009-10-27 22:46 ` [RFC PATCH 02/17] make ckpt_format_fmt non-static in checkpoint/sys.c Serge Hallyn
[not found] ` <1256683587-23961-3-git-send-email-serge-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-28 16:53 ` Matt Helsley
[not found] ` <20091028165317.GS31446-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-10-28 18:04 ` Serge E. Hallyn
[not found] ` <20091028180418.GB19554-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-28 18:31 ` Serge E. Hallyn [this message]
2009-10-28 22:21 ` Serge E. Hallyn
2009-10-27 22:46 ` [RFC PATCH 03/17] ckpt_write_err update arch/x86/mm/checkpoint.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 04/17] ckpt_write_err update checkpoint/checkpoint.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 05/17] ckpt_write_err update checkpoint/files.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 06/17] ckpt_write_err update checkpoint/memory.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 07/17] ckpt_write_err update checkpoint/objhash.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 08/17] ckpt_write_err update checkpoint/process.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 09/17] ckpt_write_err update checkpoint/signal.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 10/17] ckpt_write_err update fs/eventpoll.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 11/17] define function to print error messages to user log Serge Hallyn
[not found] ` <1256683587-23961-12-git-send-email-serge-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-28 18:14 ` Matt Helsley
[not found] ` <20091028181415.GB14023-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-10-28 20:54 ` Serge E. Hallyn
[not found] ` <20091028205424.GA27394-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-28 21:50 ` Oren Laadan
[not found] ` <4AE8BCB5.4030406-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-28 22:12 ` Serge E. Hallyn
[not found] ` <20091028221208.GA30227-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-28 22:31 ` Oren Laadan
[not found] ` <4AE8C639.6090105-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-29 0:12 ` Serge E. Hallyn
[not found] ` <20091029001223.GA1463-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-29 0:44 ` Oren Laadan
[not found] ` <4AE8E578.4030300-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-29 4:23 ` Serge E. Hallyn
[not found] ` <20091029042304.GA9005-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2009-10-29 16:02 ` Oren Laadan
2009-10-27 22:46 ` [RFC PATCH 12/17] use ckpt_error in checkpoint/restart.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 13/17] ckpt_error in checkpoint/files.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 14/17] ckpt_error in checkpoint/process.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 15/17] ckpt_error in ipc/checkpoint_msg.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 16/17] ckpt_error in ipc/checkpoint_sem.c Serge Hallyn
2009-10-27 22:46 ` [RFC PATCH 17/17] ckpt_error in ipc/checkpoint_shm.c Serge Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028183120.GA22902@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox