From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Alexey Dobriyan
<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] c/r: tolerate X86_EFLAGS_RF on restart
Date: Thu, 29 Oct 2009 09:31:25 -0500 [thread overview]
Message-ID: <20091029143125.GE15713@us.ibm.com> (raw)
In-Reply-To: <4AE8EDC4.5010202-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
Quoting Oren Laadan (orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org):
>
> After reading the code a bit more, and seeing that:
>
> 1) ptrace uses the debugreg of a process so may be interested in
> that particular flag, and
>
> 2) even without ptrace userspace can set that flag (by suitably
> setting the restore context from a signal handler)
>
> I now think that we should instead:
>
> 1) Keep the X86_EFLAGS_RF from the time of checkpoint *as is*
>
> 2) If the restarting task already has this flag set prior to
> restoring eflags from the saved value, then preserve the existing
> flag even if at the time of checkpoint it wasn't set.
>
> Unless someones yells, I'll commit this soon.
As it stands (looking at arch/x86/kernel/ptrace.c) it looks like
userspace with no privilege can set the bit right? I think your
proposal sounds best.
-serge
prev parent reply other threads:[~2009-10-29 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 18:37 [PATCH] c/r: tolerate X86_EFLAGS_RF on restart Oren Laadan
[not found] ` <1256323024-20268-1-git-send-email-orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-26 14:57 ` Serge E. Hallyn
[not found] ` <20091026145746.GA23564-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-29 1:20 ` Oren Laadan
[not found] ` <4AE8EDC4.5010202-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-29 14:31 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029143125.GE15713@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox