Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH] Add a choosepid() syscall as a simpler alternative to clone_with_pids()
Date: Mon, 2 Nov 2009 16:10:16 -0600	[thread overview]
Message-ID: <20091102221016.GA13766@us.ibm.com> (raw)
In-Reply-To: <4AEF45BB.4080609-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>

Quoting Oren Laadan (orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org):
> Hi Dan,
> 
> Two comments:
> 
> 1. We already tried a similar approach over a year ago - selecting pids
> using a /proc interface instead of a dedicated syscall - and received
> chilling reactions. (IIRC posted by Nadia Derbey).

The chilling reactions were due to (1) general objections to the functionality
of clone_with_pids() itself, (2) new procfiles, the way alloc_pid() was being
extended (i.e. that was solved by Suka as well as (1)) and especially (3) using
a generic, multiplexed 'next_id' file.

I don't think we can extrapolate from those objections to this patchset
being objectionable.

> 2. What do you expect to gain by splitting the work into two separate
> system calls ?

Two very simple syscalls which are both trivially correct and trivial
for userspace to use.

-serge

  parent reply	other threads:[~2009-11-02 22:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 20:38 [PATCH] Add a choosepid() syscall as a simpler alternative to clone_with_pids() Dan Smith
     [not found] ` <1257194293-12099-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-02 20:48   ` Oren Laadan
     [not found]     ` <4AEF45BB.4080609-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-11-02 20:52       ` Dan Smith
     [not found]         ` <87ws281weu.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-11-02 21:02           ` Oren Laadan
2009-11-02 22:10       ` Serge E. Hallyn [this message]
2009-11-03 15:44   ` Oren Laadan
     [not found]     ` <4AF04FE9.6090301-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-11-03 21:43       ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091102221016.GA13766@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox