Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Nathan Lynch <nathanl-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org>
Cc: Linux Containers
	<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
	sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] implement s390 clone_with_pids syscall
Date: Wed, 11 Nov 2009 14:37:39 -0600	[thread overview]
Message-ID: <20091111203739.GD8761@us.ibm.com> (raw)
In-Reply-To: <1257970778.7132.1364.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

Quoting Nathan Lynch (nathanl-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org):
> Something I missed earlier is that the stack_size you are passing in
> from user space is not actually the size of the stack.  It's adjusted to
> account for arguments that have been placed at the end of the stack
> region.  So stack_size becomes a value that you want the kernel to add
> to stack_base to get the desired stack pointer value in the child --
> it's not a size at all.  At this point we may as well communicate the
> desired stack pointer value directly (which could be denoted by
> stack_size == 0, or we could add another member to clone_args), or
> rename stack_size to stack_offset or similar.

So do I understand correctly that the agreement (reached on irc) is
to keep passing in a stack_size, but enforce that it ==0 for all but
ia64?

-serge

  parent reply	other threads:[~2009-11-11 20:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 16:37 [PATCH 1/1] implement s390 clone_with_pids syscall Serge E. Hallyn
     [not found] ` <20091110163708.GA19122-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-11  7:27   ` Nathan Lynch
     [not found]     ` <1257924442.7132.467.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-11-11 14:46       ` Serge E. Hallyn
     [not found]         ` <20091111144600.GA6925-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-11 16:59           ` Nathan Lynch
     [not found]             ` <1257958793.7132.1068.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-11-11 18:33               ` Serge E. Hallyn
     [not found]                 ` <20091111183303.GA8761-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-11 20:19                   ` Nathan Lynch
     [not found]                     ` <1257970778.7132.1364.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-11-11 20:37                       ` Serge E. Hallyn [this message]
     [not found]                         ` <20091111203739.GD8761-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-11 21:53                           ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091111203739.GD8761@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nathanl-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org \
    --cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox