From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH RFC] refuse checkpoint of file with f_owner
Date: Wed, 16 Dec 2009 15:22:58 -0600 [thread overview]
Message-ID: <20091216212258.GA31602@us.ibm.com> (raw)
... because we don't yet support its restore.
Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
checkpoint/files.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/checkpoint/files.c b/checkpoint/files.c
index c8e8d7f..cac5236 100644
--- a/checkpoint/files.c
+++ b/checkpoint/files.c
@@ -261,6 +261,7 @@ static int checkpoint_file_desc(struct ckpt_ctx *ctx,
struct fdtable *fdt;
int objref, ret;
int coe = 0; /* avoid gcc warning */
+ pid_t pid;
h = ckpt_hdr_get_type(ctx, sizeof(*h), CKPT_HDR_FILE_DESC);
if (!h)
@@ -283,6 +284,17 @@ static int checkpoint_file_desc(struct ckpt_ctx *ctx,
}
/*
+ * TODO: Implement c/r of fowner and f_sigio. Should be
+ * trivial, but for now we just refuse its checkpoint
+ */
+ pid = f_getown(file);
+ if (pid) {
+ ret = -EBUSY;
+ ckpt_err(ctx, ret, "%(T)fd %d has an owner (%d)\n", fd);
+ goto out;
+ }
+
+ /*
* if seen first time, this will add 'file' to the objhash, keep
* a reference to it, dump its state while at it.
*/
--
1.6.0.4
next reply other threads:[~2009-12-16 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 21:22 Serge E. Hallyn [this message]
[not found] ` <20091216212258.GA31602-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-12-16 21:24 ` [PATCH RFC] refuse checkpoint of file with f_owner Serge E. Hallyn
2009-12-23 0:49 ` Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091216212258.GA31602@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox