Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [PATCH 2/2] sem restore: don't free sma if it's an error
Date: Wed, 13 Jan 2010 13:41:21 -0600	[thread overview]
Message-ID: <20100113194121.GA26938@us.ibm.com> (raw)
In-Reply-To: <1263355761-17112-2-git-send-email-serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Quoting serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org (serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> From: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> 
> Signed-off-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
>  ipc/checkpoint_sem.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/ipc/checkpoint_sem.c b/ipc/checkpoint_sem.c
> index 53a19ed..395c84d 100644
> --- a/ipc/checkpoint_sem.c
> +++ b/ipc/checkpoint_sem.c
> @@ -186,6 +186,7 @@ int restore_ipc_sem(struct ckpt_ctx *ctx, struct ipc_namespace *ns)
>  	sma = restore_sem_array(ctx, h->sem_nsems);
>  	if (IS_ERR(sma)) {
>  		ret = PTR_ERR(sma);
> +		sma = NULL;
>  		goto out;
>  	}
> 
> -- 
> 1.6.0.6

So FWIW on x86-64 many of the tests current pass - the 3 failures I'm seeing
are due to:

	1. message queues for some reason aren't seen by the restarted
	   task (restart does think it is restoring them according to debug
	   info)
	2. self-checkpoint not yet supported
	3. restart block not set up right (or at least cr_tests/sleep fails
	   for some reason, haven't yet looked at why)

I'm trying to track down #1 right now

-serge

  parent reply	other threads:[~2010-01-13 19:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13  4:09 [PATCH 1/2] m_type is long, not int serue-r/Jw6+rmf7HQT0dZR+AlfA
     [not found] ` <1263355761-17112-1-git-send-email-serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-01-13  4:09   ` [PATCH 2/2] sem restore: don't free sma if it's an error serue-r/Jw6+rmf7HQT0dZR+AlfA
     [not found]     ` <1263355761-17112-2-git-send-email-serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-01-13 19:41       ` Serge E. Hallyn [this message]
     [not found]         ` <20100113194121.GA26938-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-01-13 20:17           ` Serge E. Hallyn
2010-01-20 17:01   ` [PATCH 1/2] m_type is long, not int Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100113194121.GA26938@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox