From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH linux-cr] x86-32 and ia32 eclone, checkpoint, restart fixes
Date: Fri, 22 Jan 2010 18:38:49 -0800 [thread overview]
Message-ID: <20100123023849.GA12398@us.ibm.com> (raw)
In-Reply-To: <20100123003447.GA5285-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Serge E. Hallyn [serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org] wrote:
| Eclone on x86-32 should use esi for 4th arg (upids), not
| edi, which is 5th arg. This will require a corresponding fix
Good catch and nice debug.
| to user-cr, but (a) it's correct and (b) it's required so that
| IA32_ARG_FIXUP can put upids in the right register for
| process_64.c:sys_eclone(). IA32_ARG_FIXUP will (of course) put
| edi into r8, the 5th arg.
|
| Add the ptregs_syscall stubs for eclone, checkpoint, and restart
| for 32-bit api on x86-64.
|
| With this patch (and proper user-cr), checkpoint and eclone work
| on x86-32, x86-64, and in 32-bit mode on x86-64. (restart has not
| yet been tested)
|
| Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
prev parent reply other threads:[~2010-01-23 2:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 0:34 [PATCH linux-cr] x86-32 and ia32 eclone, checkpoint, restart fixes Serge E. Hallyn
[not found] ` <20100123003447.GA5285-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-01-23 2:38 ` Sukadev Bhattiprolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100123023849.GA12398@us.ibm.com \
--to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox