From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 2/2] Move ckpt_objhash_free() to before we destroy the deferqueues Date: Tue, 9 Feb 2010 15:42:51 -0600 Message-ID: <20100209214251.GA1213@us.ibm.com> References: <1265736604-24194-1-git-send-email-danms@us.ibm.com> <1265736604-24194-3-git-send-email-danms@us.ibm.com> <20100209212928.GB32513@us.ibm.com> <877hqmhz80.fsf@caffeine.danplanet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <877hqmhz80.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Smith Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > SH> Well you can't quite do that bc fs/eventpoll.c:ep_items_restore() > SH> will use ckpt_obj_fetch(). > > That runs in the deferqueue_run() function, not the > deferqueue_destroy() bit, which is what I'm actually changing the > order of here. Right? Oh. Uh, yeah :) Can't see any problem with that then. We'll just need to remember (bc I can't think where to sanely document it) that deferqueue->destructor method may not use ckpt_obj_fetch(). -serge