From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org
Cc: Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: [PATCH 1/1] lxc-ps: Nit - Avoid blank CONTAINER column
Date: Wed, 10 Feb 2010 20:25:31 -0800 [thread overview]
Message-ID: <20100211042531.GA8835@us.ibm.com> (raw)
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Wed, 10 Feb 2010 20:09:17 -0800
Subject: [PATCH 1/1] lxc-ps: Nit - Avoid blank CONTAINER column
The contianer name is not printed in the lxc-ps output unless the --lxc
option is specified. But the CONTAINER column is printed (and left
blank) even if the --lxc option is not specified.
$ /usr/local/bin/lxc-ps -n foo
CONTAINER PID TTY TIME CMD
19525 pts/2 00:00:01 bash
20311 pts/2 00:00:00 lxc-ps
20312 pts/2 00:00:00 ps
Like normal ps, it would be less confusing (IMHO) if the CONTAINER
column is skipped unless the --lxc option is specified.
$ ./lxc-ps -n foo
PID TTY TIME CMD
19525 pts/2 00:00:01 bash
20339 pts/2 00:00:00 lxc-ps
20340 pts/2 00:00:00 ps
$ ./lxc-ps --lxc -n foo
CONTAINER PID TTY TIME CMD
foo 19646 pts/1 00:00:00 lxc-init
foo 19647 pts/1 00:00:00 bash
Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
src/lxc/lxc-ps.in | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/lxc/lxc-ps.in b/src/lxc/lxc-ps.in
index 249b104..e1aa655 100755
--- a/src/lxc/lxc-ps.in
+++ b/src/lxc/lxc-ps.in
@@ -124,7 +124,11 @@ sub get_container {
}
sub display_headers {
- printf "%-10s %s", "CONTAINER", $PS_HEADERS;
+ if ($LXC_DISPLAY) {
+ printf "%-10s %s", "CONTAINER", $PS_HEADERS;
+ } else {
+ printf "%s", $PS_HEADERS;
+ }
}
sub display_usage {
@@ -195,7 +199,11 @@ for (@PS_LINES) {
my $container = get_container $a[$PS_PID_INDEX];
if ($LXC_DISPLAY == 2 and not $LXC_NAMES{$container}) {next;}
if ($LXC_DISPLAY == 1 and $container eq '') {next;}
- printf "%-10s %s", $container, $_;
+ if ($LXC_DISPLAY) {
+ printf "%-10s %s", $container, $_;
+ } else {
+ printf "%s", $_;
+ }
}
exit 0;
--
1.6.6.1
next reply other threads:[~2010-02-11 4:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 4:25 Sukadev Bhattiprolu [this message]
[not found] ` <20100211042531.GA8835-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-11 10:08 ` [PATCH 1/1] lxc-ps: Nit - Avoid blank CONTAINER column Michel Normand
2010-02-11 10:21 ` [lxc-devel] " Michel Normand
[not found] ` <1265883662.2591.68.camel@pagloppaglop>
2010-02-11 15:54 ` Serge E. Hallyn
[not found] ` <20100211155446.GC6884@us.ibm.com>
[not found] ` <20100211155446.GC6884-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-11 18:19 ` Sukadev Bhattiprolu
[not found] ` <20100211181902.GA3742-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-12 7:48 ` Michel Normand
2010-02-12 16:54 ` Cedric Le Goater
2010-02-12 17:01 ` Cedric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100211042531.GA8835@us.ibm.com \
--to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox