Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH user-cr] use syscall(NR_getpid) to avoid cached pid
Date: Tue, 16 Feb 2010 18:24:09 -0600	[thread overview]
Message-ID: <20100217002409.GA3267@us.ibm.com> (raw)

otherwise glibc caches getpid() result and we put the parent
process in the new cgroup, in the case of 'nsexec -cg /bin/sleep 10'

Signed-off-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
 nsexec.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/nsexec.c b/nsexec.c
index 3a825f1..79fcc70 100644
--- a/nsexec.c
+++ b/nsexec.c
@@ -154,7 +154,7 @@ int move_to_new_cgroup(int newcgroup)
 	fout = fopen(tasksfname, "w");
 	if (!fout)
 		return 0;
-	fprintf(fout, "%d\n", getpid());
+	fprintf(fout, "%d\n", syscall(__NR_getpid));
 	fclose(fout);
 	return 1;
 }
@@ -193,7 +193,7 @@ int do_child(void *vargv)
 
 	/* if pid == 1 then remount /proc */
 	/* But if the container has no /proc don't fret */
-	if (getpid() == 1) {
+	if (syscall(__NR_getpid) == 1) {
 		umount2("/proc", MNT_DETACH);
 		mount("proc", "/proc", "proc", 0, NULL);
 	}
-- 
1.6.4.4

             reply	other threads:[~2010-02-17  0:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17  0:24 Serge E. Hallyn [this message]
     [not found] ` <20100217002409.GA3267-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-18  0:57   ` [PATCH user-cr] use syscall(NR_getpid) to avoid cached pid Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217002409.GA3267@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox