Linux Container Development
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: [PATCH][user-cr]: ckptinfo: Have -v imply -p option
Date: Fri, 19 Feb 2010 11:36:43 -0800	[thread overview]
Message-ID: <20100219193643.GA332@us.ibm.com> (raw)


Do we even need the -p option ? It is not used without the -v at present.
Can we drop the -p and have -v print filepos always ?

---
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Fri, 19 Feb 2010 11:19:08 -0800
Subject: [PATCH 1/1] ckptinfo: Have -v imply -p

When the -v is chosen, user wants verbose debug information. The
filepos would be useful to correlate with the kernel debug messages
and does not clutter the output.

Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
 ckptinfo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ckptinfo.c b/ckptinfo.c
index 6859742..be91b80 100644
--- a/ckptinfo.c
+++ b/ckptinfo.c
@@ -135,7 +135,7 @@ int main(int argc, char *argv[])
 
 	if (args.verbose)
 		__verbose = 1;
-	if (args.position)
+	if (args.position || args.verbose)
 		__position = 1;
 
 	argc -= optind;
-- 
1.6.6.1

             reply	other threads:[~2010-02-19 19:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19 19:36 Sukadev Bhattiprolu [this message]
     [not found] ` <20100219193643.GA332-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-22 22:52   ` [PATCH][user-cr]: ckptinfo: Have -v imply -p option Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100219193643.GA332@us.ibm.com \
    --to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox