Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Sukadev Bhattiprolu
	<sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	sukadev-6JnAsaTVvkgX0ybBhKVfKdBPR1lH4CV8@public.gmane.org
Subject: Re: [PATCH 0/12][user-cr]: Second set of cleanups
Date: Mon, 8 Mar 2010 13:49:23 -0600	[thread overview]
Message-ID: <20100308194923.GC20030@us.ibm.com> (raw)
In-Reply-To: <20100305223439.GA15300-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org):
> 
> Second set of cleanup patches. With these patches, LXC will be able
> to compile/link directly using restart.o and app-checkpoint.h from
> the user-cr directory. Something like:
> 
> 	USER_CR=/home/suka/user-cr make lxc_restart
> 
> After having more detailed discussions on the API, we could install
> restart.o in /lib/libcheckpoint.a and app-checkpoint.h in /usr/include.
> 
> 	[PATCH 01/12][user-cr] restart: Mark globals as static
> 	[PATCH 02/12][user-cr] restart: Add args->send_sigint
> 	[PATCH 03/12][user-cr] Add app_restart_args->debug
> 	[PATCH 04/12][user-cr] Add app_restart_args->verbose
> 	[PATCH 05/12][user-cr] Add app_restart_args->ulogfd
> 	[PATCH 06/12][user-cr] Add app_restart_args->uerrfd
> 	[PATCH 07/12][user-cr] Define INIT_SIGNAL_ARRAY
> 	[PATCH 08/12][user-cr] Create common.h 
> 	[PATCH 09/12][user-cr] Create app-checkpoint.h
> 	[PATCH 10/12][user-cr] restart: Move main() to restart-main.c
> 	[PATCH 11/12][user-cr] checkpoint: Move main() to checkpoint-main.c
> 	[PATCH 12/12][user-cr] Have app_restart() return pid
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

Again, not yet tested (though will do that soon as I will base my
mounts c/r patchset on ckpt-v19-suka), but looks good, thanks.

Acked-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

-serge

      parent reply	other threads:[~2010-03-08 19:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-05 22:34 [PATCH 0/12][user-cr]: Second set of cleanups Sukadev Bhattiprolu
     [not found] ` <20100305223439.GA15300-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-05 22:36   ` [PATCH 01/12][user-cr] restart: Mark globals as static Sukadev Bhattiprolu
2010-03-05 22:36   ` [PATCH 02/12][user-cr] restart: Add args->send_sigint Sukadev Bhattiprolu
     [not found]     ` <20100305223658.GB15939-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-15  3:52       ` Oren Laadan
2010-03-05 22:37   ` [PATCH 03/12][user-cr] Add app_restart_args->debug Sukadev Bhattiprolu
     [not found]     ` <20100305223723.GC15939-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-08 19:39       ` Serge E. Hallyn
     [not found]         ` <20100308193929.GA20030-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-08 20:42           ` Sukadev Bhattiprolu
2010-03-05 22:37   ` [PATCH 04/12][user-cr] Add app_restart_args->verbose Sukadev Bhattiprolu
2010-03-05 22:38   ` [PATCH 05/12][user-cr] Add app_restart_args->ulogfd Sukadev Bhattiprolu
2010-03-05 22:38   ` [PATCH 06/12][user-cr] Add app_restart_args->uerrfd Sukadev Bhattiprolu
2010-03-05 22:38   ` [PATCH 07/12][user-cr] Define INIT_SIGNAL_ARRAY Sukadev Bhattiprolu
2010-03-05 22:39   ` [PATCH 08/12][user-cr] Create common.h Sukadev Bhattiprolu
     [not found]     ` <20100305223907.GH15939-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-08 19:44       ` Serge E. Hallyn
     [not found]         ` <20100308194427.GB20030-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-08 20:22           ` Sukadev Bhattiprolu
2010-03-05 22:39   ` [PATCH 09/12][user-cr] Create app-checkpoint.h Sukadev Bhattiprolu
2010-03-05 22:39   ` [PATCH 10/12][user-cr] restart: Move main() to restart-main.c Sukadev Bhattiprolu
2010-03-05 22:40   ` [PATCH 11/12][user-cr] checkpoint: Move main() to checkpoint-main.c Sukadev Bhattiprolu
2010-03-05 22:40   ` [PATCH 12/12][user-cr] Have app_restart() return pid Sukadev Bhattiprolu
2010-03-08 19:49   ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100308194923.GC20030@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=sukadev-6JnAsaTVvkgX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox