From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>,
Sukadev Bhattiprolu
<sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH user-cr] restart: unshare mounts ns when unsharing pidns (for --pidns)
Date: Wed, 24 Mar 2010 11:02:51 -0500 [thread overview]
Message-ID: <20100324160251.GA18717@us.ibm.com> (raw)
NOTE - this is against Suka's latest user-cr patchset. Without
this patch, the cr_tests/simple testcase ends up remounting
/proc at restart without having unshared mounts. Therefore,
after running the testcase no tasks show up in /proc.
With this patch on top of Suka's user-cr patchset, all cr_tests
pass.
Signed-off-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
restart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/restart.c b/restart.c
index 484668a..677033d 100644
--- a/restart.c
+++ b/restart.c
@@ -554,7 +554,7 @@ int app_restart(struct app_restart_args *args)
ret = ckpt_coordinator_pidns(&ctx);
} else if (ctx.args->pidns) {
ckpt_dbg("new pidns with init\n");
- ctx.tasks_arr[0].flags |= TASK_NEWPID;
+ ctx.tasks_arr[0].flags |= TASK_NEWPID | TASK_NEWNS;
if (global_send_sigint == -1)
global_send_sigint = SIGKILL;
ret = ckpt_coordinator(&ctx);
--
1.7.0
next reply other threads:[~2010-03-24 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 16:02 Serge E. Hallyn [this message]
[not found] ` <20100324160251.GA18717-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-30 7:07 ` [PATCH user-cr] restart: unshare mounts ns when unsharing pidns (for --pidns) Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324160251.GA18717@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
--cc=sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox