From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 1/8] checkpoint: model ckpt_siginfo on signalfd_siginfo
Date: Thu, 15 Jul 2010 17:55:46 -0700 [thread overview]
Message-ID: <20100716005546.GA8572@us.ibm.com> (raw)
In-Reply-To: <1279035864-10533-2-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Nathan Lynch [ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org] wrote:
| ckpt_siginfo doesn't cover all of the possible siginfo fields; the
| current code overloads some fields (such as si_uid for si_overrun),
| which is confusing. Signed-ness on some fields is not correct either.
|
| signalfd_siginfo is a straightforward format for representing siginfo,
| so copy it and update the signal checkpoint code to use the new
| fields. Although the ckpt_siginfo struct grows, there should be no
| behavioral changes.
|
| Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Switching to the signalfd_siginfo style makes it more easier to
maintain. So for all patches in this set:
Reviewed-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
next prev parent reply other threads:[~2010-07-16 0:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 15:44 [PATCH 0/8] checkpoint: improve handling of pending signals Nathan Lynch
[not found] ` <1279035864-10533-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2010-07-13 15:44 ` [PATCH 1/8] checkpoint: model ckpt_siginfo on signalfd_siginfo Nathan Lynch
[not found] ` <1279035864-10533-2-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2010-07-16 0:55 ` Sukadev Bhattiprolu [this message]
2010-07-13 15:44 ` [PATCH 2/8] checkpoint: add const qualifiers to siginfo handlers Nathan Lynch
[not found] ` <1279035864-10533-3-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2010-07-13 23:29 ` Matt Helsley
2010-07-13 15:44 ` [PATCH 3/8] checkpoint: clean up pending posix timer signal handling Nathan Lynch
2010-07-13 15:44 ` [PATCH 4/8] checkpoint: clean up __SI_POLL siginfo save/restore Nathan Lynch
2010-07-13 15:44 ` [PATCH 5/8] checkpoint: clean up __SI_FAULT " Nathan Lynch
2010-07-13 15:44 ` [PATCH 6/8] checkpoint: clean up __SI_CHLD " Nathan Lynch
2010-07-13 15:44 ` [PATCH 7/8] checkpoint: __SI_KILL does not use si_ptr Nathan Lynch
2010-07-13 15:44 ` [PATCH 8/8] checkpoint: handle siginfo->si_code < 0 Nathan Lynch
2010-07-13 22:22 ` [PATCH 9/8] restore_sigpending: fix reversed list_add_tail arguments Nathan Lynch
2010-07-13 23:36 ` Matt Helsley
2010-07-20 3:00 ` [PATCH 0/8] checkpoint: improve handling of pending signals Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716005546.GA8572@us.ibm.com \
--to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox