From: Brad Boyer <flar-POGeQm5F+FGB+jHODAdFcQ@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Andreas Dilger
<adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/6] [RFC] Create the .relink file_operation
Date: Sun, 26 Sep 2010 12:08:37 -0700 [thread overview]
Message-ID: <20100926190837.GA9308@cynthia.pants.nu> (raw)
In-Reply-To: <d91e3660266d3a2956c4d1aebc9cb618081b21ef.1285278339.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
On Thu, Sep 23, 2010 at 02:53:28PM -0700, Matt Helsley wrote:
> Not all filesystems will necessarily be able to support relinking an
> orphan inode back into the filesystem. Some offlist feedback suggested
> that instead of overloading .link that relinking should be a separate
> file operation for this reason.
>
> Since .relink is a superset of .link make the VFS call .relink where
> possible and .link otherwise.
>
> The next commit will change ext3/4 to enable this operation.
I may have missed something in one of these patches (patch 1 and any
original summary if there was one don't appear in my email), but
what is the point of the new operation? I didn't see any case that
treats one any different than the other. What is disallowed (and how)
for a driver which does not implement .relink but has .link?
Brad Boyer
flar-POGeQm5F+FGB+jHODAdFcQ@public.gmane.org
next prev parent reply other threads:[~2010-09-26 19:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 21:53 [PATCH 0/6] Relink unlinked files for checkpoint/restart support Matt Helsley
[not found] ` <1285278812-16972-1-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-09-23 21:53 ` [PATCH 1/6] Move sys-wrappers Matt Helsley
[not found] ` <6987185123220ec2034677299859c5a63eaf2aed.1285278339.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-09-23 21:53 ` [PATCH 2/6] [RFC] Create the .relink file_operation Matt Helsley
2010-09-23 21:53 ` [PATCH 3/6] [RFC] ext3/4: Allow relinking to unlinked files Matt Helsley
2010-09-23 21:53 ` [PATCH 4/6] [RFC] Split do_linkat() out of sys_linkat Matt Helsley
2010-09-23 21:53 ` [PATCH 5/6] [RFC] Checkpoint/restart unlinked files Matt Helsley
2010-09-23 21:53 ` [PATCH 6/6] [RFC] Enable c/r of unlinked fifos Matt Helsley
[not found] ` <d91e3660266d3a2956c4d1aebc9cb618081b21ef.1285278339.git.matthltc@us.ibm.com>
[not found] ` <d91e3660266d3a2956c4d1aebc9cb618081b21ef.1285278339.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-09-26 19:08 ` Brad Boyer [this message]
[not found] ` <20100926190837.GA9308-gUHvAUm18WIVF38mYka5EQ@public.gmane.org>
2010-09-27 19:16 ` [PATCH 2/6] [RFC] Create the .relink file_operation Matt Helsley
[not found] ` <20100927191628.GN23839@count0.beaverton.ibm.com>
[not found] ` <20100927191628.GN23839-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-09-27 22:03 ` Brad Boyer
[not found] ` <20100927220346.GA30726@cynthia.pants.nu>
[not found] ` <20100927220346.GA30726-gUHvAUm18WIVF38mYka5EQ@public.gmane.org>
2010-09-29 20:16 ` Oren Laadan
2010-09-29 20:19 ` Oren Laadan
[not found] ` <59e9d9fe9db11c6e06ef314541b1112f2b720a59.1285278339.git.matthltc@us.ibm.com>
[not found] ` <9eade1f1ec10c23dae296feda8af9fe87085e843.1285278339.git.matthltc@us.ibm.com>
[not found] ` <9eade1f1ec10c23dae296feda8af9fe87085e843.1285278339.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-09-29 20:28 ` [PATCH 4/6] [RFC] Split do_linkat() out of sys_linkat Oren Laadan
[not found] ` <7da8a050193a91b69ecb3899ce2eda541ecd2473.1285278339.git.matthltc@us.ibm.com>
[not found] ` <7da8a050193a91b69ecb3899ce2eda541ecd2473.1285278339.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-09-29 22:22 ` [PATCH 5/6] [RFC] Checkpoint/restart unlinked files Oren Laadan
2010-10-22 23:43 ` Sukadev Bhattiprolu
[not found] ` <4CA3BC2D.8010001@cs.columbia.edu>
[not found] ` <4CA3BC2D.8010001-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2010-09-30 1:17 ` Matt Helsley
[not found] ` <20100930011711.GT23839@count0.beaverton.ibm.com>
[not found] ` <20100930011711.GT23839-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-09-30 15:45 ` Oren Laadan
[not found] ` <4CA39F53.6040506@cs.columbia.edu>
[not found] ` <4CA39F53.6040506-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2010-09-29 23:07 ` [PATCH 2/6] [RFC] Create the .relink file_operation Matt Helsley
2010-11-01 16:38 ` [PATCH 0/6] Relink unlinked files for checkpoint/restart support Oren Laadan
[not found] ` <4CCEECFF.9010909-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2010-11-01 20:43 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926190837.GA9308@cynthia.pants.nu \
--to=flar-pogeqm5f+fgb+jhodadfcq@public.gmane.org \
--cc=adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox