Linux Container Development
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Stephen Hemminger
	<shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>,
	Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: cgroup debug seems dead?
Date: Wed, 20 Oct 2010 12:49:21 +0800	[thread overview]
Message-ID: <20101020044921.GC5316@cr0.nay.redhat.com> (raw)
In-Reply-To: <4CBE52AE.2010409-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>

On Wed, Oct 20, 2010 at 10:23:42AM +0800, Li Zefan wrote:
>Stephen Hemminger wrote:
>> On Wed, 20 Oct 2010 09:43:06 +0800
>> Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote:
>> 
>>> Stephen Hemminger wrote:
>>>> On Tue, 19 Oct 2010 18:14:10 -0700
>>>> Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
>>>>
>>>>> On Tue, Oct 19, 2010 at 6:12 PM, Stephen Hemminger
>>>>> <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org> wrote:
>>>>>> Where is it stored in an array?
>>>>>>
>>>>>> ~/kernel/linux-2.6$ git grep debug_subsys
>>>>>> kernel/cgroup.c:        kfree(cont->subsys[debug_subsys_id]);
>>>>>> kernel/cgroup.c:struct cgroup_subsys debug_subsys = {
>>>>>> kernel/cgroup.c:        .subsys_id = debug_subsys_id,
>>>>> It's via the include of cgroup_subsys.h at the start of kernel/cgroup.c
>>>>>
>>>>> Paul
>>>> That would work but doesn't because the following is missing
>>>> in cgroup_subsys.h!
>>> It's there in cgroup_subsys.h (2.6.36-rc8). What kernel are you using?
>> 
>> Found it, thanks. Still not sure why the tools were confused.
>> 
>
>That's normal. Think about how many false positives we can get with
>checkpatch.pl.
>
>Your tools should be static code analyzers, and the macro we use in cgroup
>is too complex for them.

namespace.pl is not that static. Becuase it checks the binary not
the source, a little more dynamic that you think. ;)

Stephen, what message did you see?

      parent reply	other threads:[~2010-10-20  4:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 15:51 cgroup debug seems dead? Stephen Hemminger
2010-10-20  1:11 ` Li Zefan
     [not found]   ` <4CBE41AE.2020101-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-20  1:12     ` Stephen Hemminger
2010-10-20  1:14       ` Paul Menage
     [not found]         ` <AANLkTinH2t41jvGG_D9qAdN5MvRHg7aR+J2mKV5ifMfC-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-20  1:37           ` Stephen Hemminger
2010-10-20  1:42             ` Paul Menage
2010-10-20  1:43             ` Li Zefan
     [not found]               ` <4CBE492A.3020208-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-20  2:14                 ` Stephen Hemminger
2010-10-20  2:23                   ` Li Zefan
     [not found]                     ` <4CBE52AE.2010409-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-20  4:49                       ` Américo Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101020044921.GC5316@cr0.nay.redhat.com \
    --to=xiyou.wangcong-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
    --cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox