Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
To: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>,
	Linux Containers
	<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Cc: stgraber-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org
Subject: [PATCH 1/1] templates: don't put devpts in $confdir/container/fstab
Date: Fri, 6 May 2011 12:05:17 -0500	[thread overview]
Message-ID: <20110506170516.GA20670@mail.hallyn.com> (raw)

src/lxc/conf.c will explicitly mount it anyway.  Furthermore, the fstab
entry, which is getting processed first, did not specify -o newinstance.
This can cause the host's devpts entry mount options to change, as in
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/607636.

I believe the lenny, fedora, and debian templates also will need an
update.

Signed-off-by: Serge Hallyn <serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
---
 templates/lxc-lucid.in    |    1 -
 templates/lxc-maverick.in |    1 -
 templates/lxc-natty.in    |    1 -
 3 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/templates/lxc-lucid.in b/templates/lxc-lucid.in
index fb5aa6f..fe61313 100644
--- a/templates/lxc-lucid.in
+++ b/templates/lxc-lucid.in
@@ -260,7 +260,6 @@ EOF
 
     cat <<EOF > $path/fstab
 proc            $rootfs/proc         proc    nodev,noexec,nosuid 0 0
-devpts          $rootfs/dev/pts      devpts defaults 0 0
 sysfs           $rootfs/sys          sysfs defaults  0 0
 EOF
 
diff --git a/templates/lxc-maverick.in b/templates/lxc-maverick.in
index a85a6ca..0a8ac8e 100644
--- a/templates/lxc-maverick.in
+++ b/templates/lxc-maverick.in
@@ -183,7 +183,6 @@ EOF
 
     cat <<EOF > $path/fstab
 proc            $rootfs/proc         proc    nodev,noexec,nosuid 0 0
-devpts          $rootfs/dev/pts      devpts defaults 0 0
 sysfs           $rootfs/sys          sysfs defaults  0 0
 EOF
 
diff --git a/templates/lxc-natty.in b/templates/lxc-natty.in
index c71596e..e7e3859 100644
--- a/templates/lxc-natty.in
+++ b/templates/lxc-natty.in
@@ -184,7 +184,6 @@ EOF
 
     cat <<EOF > $path/fstab
 proc            $rootfs/proc         proc    nodev,noexec,nosuid 0 0
-devpts          $rootfs/dev/pts      devpts defaults 0 0
 sysfs           $rootfs/sys          sysfs defaults  0 0
 EOF
 
-- 
1.7.4.1

             reply	other threads:[~2011-05-06 17:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 17:05 Serge E. Hallyn [this message]
     [not found] ` <20110506170516.GA20670-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2011-05-06 23:36   ` [PATCH 1/1] templates: don't put devpts in $confdir/container/fstab Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110506170516.GA20670@mail.hallyn.com \
    --to=serge-a9i7lubdfnhqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
    --cc=stgraber-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox