From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [RFC] fix devpts mount behavior Date: Tue, 24 Jan 2012 12:55:02 -0800 Message-ID: <20120124205502.GC20039@us.ibm.com> References: <20120124000517.GA28878@sergelap> <20120124002555.GA29534@sergelap> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Linus Torvalds Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Dave Hansen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Al Viro , Andy Whitcroft List-Id: containers.vger.kernel.org Linus Torvalds [torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org] wrote: | On Mon, Jan 23, 2012 at 4:25 PM, Serge Hallyn | wrote: | > | > The only place that *might* be a problem is if initramsfs does a devpts | > mount, and later init blindly mounts tmpfs on /dev and mounts a new | > devpts. =A0But it seems unlikely there would be any open pty's so it | > shouldn't really matter. | = | Right. I think the opportunity for problems should be pretty small. | = | And it's not like the pty itself wouldn't continue to work - it's just | that programs like /usr/bin/tty wouldn't be able to *find* it. | = | Although who knows - maybe there is some other subtle interaction. | = | > I could go ahead and test that, say, ubuntu and fedora systems boot fine | > with this change. =A0But of course I can't be sure there is no userspace | > out there that won't cope... | = | I think the only way is to try it out. | = | If you can test a few distros and at least validate that the approach | isn't *totally* broken, I'll apply it. It's early days in the -rc | series yet, and this does seem to be one of those things that we'd be | better off trying to do early rather than delay. Yes, hopefully the new distros can cope with 'newinstance' as the default and ones that can't can live with CONFIG_DEVPTS_MULTIPLE_INSTANCES=3Dn. Sukadev