From: Cyrill Gorcunov <gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
To: "Muralidhar,
Rajeev D"
<rajeev.d.muralidhar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "criu-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org"
<criu-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>,
"containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
Andrey Vagin <avagin-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>,
Pavel Emelyanov <xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Subject: Re: [CRIU] Re: Error compiling CRtools-0.1..
Date: Thu, 30 Aug 2012 17:47:30 +0400 [thread overview]
Message-ID: <20120830134730.GC22033@moon> (raw)
In-Reply-To: <20120830134513.GM21422@moon>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On Thu, Aug 30, 2012 at 05:45:13PM +0400, Cyrill Gorcunov wrote:
> On Thu, Aug 30, 2012 at 01:43:05PM +0000, Muralidhar, Rajeev D wrote:
> > Hi Cyril
> >
> > I took the current git snapshot from crtools repo. Should I try version 0.1 from the tar file?
>
> No no, that's fine. I'm cooking a patch. Please wait a bit.
Does the patch below helps for you?
Andrew, why did we mangle the paths to unix names?
Cyrill
[-- Attachment #2: 0001-sk-unix.c-Don-t-mangle-name-provided-by-fiag-message.patch --]
[-- Type: text/plain, Size: 992 bytes --]
From 0b01d629e136b328fe4ce85f50d54dea9aaa0728 Mon Sep 17 00:00:00 2001
From: Cyrill Gorcunov <gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Date: Thu, 30 Aug 2012 17:43:34 +0400
Subject: [PATCH] sk-unix.c: Don't mangle name provided by fiag message
Otherwise we can't fetch stat.
Reported-by: "Muralidhar, Rajeev D" <rajeev.d.muralidhar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Cyrill Gorcunov <gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
---
sk-unix.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sk-unix.c b/sk-unix.c
index 9a9323c..605e32b 100644
--- a/sk-unix.c
+++ b/sk-unix.c
@@ -277,7 +277,7 @@ static int unix_collect_one(const struct unix_diag_msg *m,
}
uv = RTA_DATA(tb[UNIX_DIAG_VFS]);
- snprintf(rpath, sizeof(rpath), ".%s", name);
+ snprintf(rpath, sizeof(rpath), "%s", name);
if (fstatat(mntns_root, rpath, &st, 0)) {
pr_perror("Can't stat socket %d(%s)",
m->udiag_ino, rpath);
--
1.7.7.6
[-- Attachment #3: Type: text/plain, Size: 205 bytes --]
_______________________________________________
Containers mailing list
Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linuxfoundation.org/mailman/listinfo/containers
next prev parent reply other threads:[~2012-08-30 13:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 11:10 Error compiling CRtools-0.1 Muralidhar, Rajeev D
[not found] ` <604C0E70D2B64644B0BCE6939D9F7D0327A1C6-yHIBzpp8AekFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-08-30 7:15 ` Muralidhar, Rajeev D
[not found] ` <604C0E70D2B64644B0BCE6939D9F7D0327E011-yHIBzpp8AekFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-08-30 12:55 ` Serge Hallyn
2012-08-30 13:10 ` [CRIU] " Cyrill Gorcunov
2012-08-30 13:16 ` Muralidhar, Rajeev D
[not found] ` <604C0E70D2B64644B0BCE6939D9F7D0327E623-yHIBzpp8AekFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-08-30 13:30 ` Cyrill Gorcunov
2012-08-30 13:43 ` Muralidhar, Rajeev D
[not found] ` <604C0E70D2B64644B0BCE6939D9F7D0327E674-yHIBzpp8AekFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-08-30 13:45 ` Cyrill Gorcunov
2012-08-30 13:47 ` Cyrill Gorcunov [this message]
2012-08-30 13:59 ` Muralidhar, Rajeev D
[not found] ` <604C0E70D2B64644B0BCE6939D9F7D0327E6C0-yHIBzpp8AekFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-08-30 14:04 ` Cyrill Gorcunov
2012-08-30 14:27 ` Muralidhar, Rajeev D
[not found] ` <604C0E70D2B64644B0BCE6939D9F7D0327E721-yHIBzpp8AekFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-08-30 14:33 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830134730.GC22033@moon \
--to=gorcunov-gefaqzzx7r8dnm+yrofe0a@public.gmane.org \
--cc=avagin-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=criu-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=rajeev.d.muralidhar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox