From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN for PF_NOFREEZE or PF_FREEZER_SKIP tasks Date: Wed, 24 Oct 2012 15:06:51 -0400 Message-ID: <20121024190651.GC12182@atj.dyndns.org> References: <1350426526-14254-1-git-send-email-tj@kernel.org> <1350426526-14254-5-git-send-email-tj@kernel.org> <20121022183453.GA24687@redhat.com> <20121022211822.GF5951@atj.dyndns.org> <20121023155533.GC16201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20121023155533.GC16201-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oleg Nesterov Cc: rjw-KKrjLPT3xs0@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org Hello, Oleg. On Tue, Oct 23, 2012 at 05:55:33PM +0200, Oleg Nesterov wrote: > > Ooh, ouch, definitely. We should clear that. Can you please make a > > patch? > > Sure... but what do you think is better? > > I'd prefer to simply clear PF_NOFREEZE (without set_freezable), but > obviously this doesn't look exactly right from cgroup_freezer pov. I don't think it matters all that much. It's a pretty special case. Maybe define PF_CLEAR_ON_EXEC_MASK or something and just include PF_NOFREEZE in it? Thanks. -- tejun