From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCHSET] cgroup: simplify cgroup removal path Date: Wed, 31 Oct 2012 10:18:49 -0700 Message-ID: <20121031171849.GH2945@htj.dyndns.org> References: <1351657365-25055-1-git-send-email-tj@kernel.org> <50912C6D.6020000@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <50912C6D.6020000-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Glauber Costa Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Hello, On Wed, Oct 31, 2012 at 05:49:33PM +0400, Glauber Costa wrote: > The only think that drew my attention is that you are changing the > local_irq_save callsite to local_irq_disable. It shouldn't be a problem, > since this is never expected to be called in interrupt context. > > Still... it makes me wonder if that disabled-interrupt block is still > needed? According to the changelogs, it was introduced in e7c5ec919 for > the css_tryget mechanism. But css_tryget itself will never scan > subsystems, so if we can no longer fail, we should be able to just ditch > it. Unless I am missing something Note both in the commit messages. Thanks. -- tejun