From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH 1/8] cgroup: kill cgroup_subsys->__DEPRECATED_clear_css_refs Date: Wed, 31 Oct 2012 22:23:42 +0100 Message-ID: <20121031212342.GA5286@dhcp22.suse.cz> References: <1351712650-23709-1-git-send-email-tj@kernel.org> <1351712650-23709-2-git-send-email-tj@kernel.org> <20121031201227.GF1271@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org On Wed 31-10-12 13:14:07, Tejun Heo wrote: > Hey, Michal. > > On Wed, Oct 31, 2012 at 1:12 PM, Michal Hocko wrote: > > And sorry for being to annoying about this WARN_ON_ONCE but I really > > don't see any reason for it. pre_destroy can still happen and now it is > > even reduced to a reasonable condition (somebody shown up). So I would > > put it out of way as it doesn't give us anything and as I've already > > mentioned one can trigger it really easily. > > It was there before and goes away in several commits. I have to > explain all that to remove it in this patch. Why do that when the > whole thing is just gonna disappear anyway? I would consider it nicer but if you feel it is not worth it then don't worry. It is not a big deal. The important part is that we do not ignore the return value now. Thanks -- Michal Hocko SUSE Labs