From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH 1/3] cpuset: implement cgroup_rightmost_descendant() Date: Mon, 3 Dec 2012 17:03:10 +0100 Message-ID: <20121203160310.GD17093@dhcp22.suse.cz> References: <1354141621-11906-1-git-send-email-tj@kernel.org> <1354141621-11906-2-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1354141621-11906-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org On Wed 28-11-12 14:26:59, Tejun Heo wrote: > Implement cgroup_rightmost_descendant() which returns the right most > descendant of the specified cgroup. This can be used to skip the > cgroup's subtree while iterating with > cgroup_for_each_descendant_pre(). > > Signed-off-by: Tejun Heo > Cc: Michal Hocko Acked-by: Michal Hocko Just a nit bellow [...] > +/** > + * cgroup_rightmost_descendant - return the rightmost descendant of a cgroup > + * @cgrp: cgroup of interest > + * > + * Return the rightmost descendant of @cgrp. If there's no descendant, > + * @cgrp is returned. This can be used during pre-order traversal to skip > + * subtree of @cgrp. > + */ s/cgrp/pos/ > +struct cgroup *cgroup_rightmost_descendant(struct cgroup *pos) [...] Thanks -- Michal Hocko SUSE Labs