From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCHSET] perf, cgroup: implement hierarchy support for perf_event controller Date: Wed, 10 Apr 2013 11:37:55 +0200 Message-ID: <20130410093755.GC24443@gmail.com> References: <1365474213-13354-1-git-send-email-tj@kernel.org> <1365579146.30071.24.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1365579146.30071.24.camel@laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Peter Zijlstra Cc: namhyung.kim-Hm3cg6mZ9cc@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, eranian-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org, acme-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org, Tejun Heo , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org * Peter Zijlstra wrote: > On Mon, 2013-04-08 at 19:23 -0700, Tejun Heo wrote: > > perf_event cgroup controller is one of the remaining few with broken > > hierarchy support. It turns out it's pretty easy to implement - the > > only thing necessary is making perf_cgroup_match() return %true also > > when the cgroup of the current task is a descendant of the event's > > cgroup. This patchset implements cgroup_is_descendant() and uses it > > to implement hierarchy support in perf_event controller. > > > > This patchset contains the following three patches. > > > > 0001-cgroup-make-sure-parent-won-t-be-destroyed-before-it.patch > > 0002-cgroup-implement-cgroup_is_descendant.patch > > 0003-perf-make-perf_event-cgroup-hierarchical.patch > > Thanks, looks simple and straight fwd. > > > Ingo, how should these be routed? > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git perf_event-hierarchy-support > > Ingo typically likes multi-maintainer sets to be pulled from a common > tree into all relevant maintainer trees so that git merges afterwards > just-work (tm). But I'll let him expand. Yeah - at least for larger changes that's a good workflow. For smaller changes we can pick one or the other tree. Tejun, do these changes create any conflicts with the current tip:master tree? If not then you could carry these changes in your tree. If there's significant conflicts then it might be better to rebase this on top of perf/core and pull them into perf/core. (assuming there's no other cgroups prereq patches beyond the ones in this series.) Thanks, Ingo