From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aristeu Rozanski Subject: Re: [PATCH] devcg: remove parent_cgroup. Date: Tue, 16 Apr 2013 17:10:10 -0400 Message-ID: <20130416211010.GQ24899@redhat.com> References: <1366143895-21535-1-git-send-email-ramirose@gmail.com> <20130416203700.GP24899@redhat.com> <20130416210725.GA21536@sergelap> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130416210725.GA21536@sergelap> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Serge Hallyn Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Rami Rosen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org On Tue, Apr 16, 2013 at 04:07:25PM -0500, Serge Hallyn wrote: > Quoting Aristeu Rozanski (aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org): > > On Tue, Apr 16, 2013 at 11:24:55PM +0300, Rami Rosen wrote: > > > In devcgroup_css_alloc(), there is no longer need for parent_cgroup. > > > bd2953ebbb("devcg: propagate local changes down the hierarchy") made > > > the variable parent_cgroup redundant. This patch removes parent_cgroup > > > from devcgroup_css_alloc(). > > > > > > Signed-off-by: Rami Rosen > > > --- > > > security/device_cgroup.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/security/device_cgroup.c b/security/device_cgroup.c > > > index 994aecc..dd0dc57 100644 > > > --- a/security/device_cgroup.c > > > +++ b/security/device_cgroup.c > > > @@ -236,7 +236,6 @@ static void devcgroup_offline(struct cgroup *cgroup) > > > static struct cgroup_subsys_state *devcgroup_css_alloc(struct cgroup *cgroup) > > > { > > > struct dev_cgroup *dev_cgroup; > > > - struct cgroup *parent_cgroup; > > > > > > dev_cgroup = kzalloc(sizeof(*dev_cgroup), GFP_KERNEL); > > > if (!dev_cgroup) > > > @@ -244,7 +243,6 @@ static struct cgroup_subsys_state *devcgroup_css_alloc(struct cgroup *cgroup) > > > INIT_LIST_HEAD(&dev_cgroup->exceptions); > > > INIT_LIST_HEAD(&dev_cgroup->propagate_pending); > > > dev_cgroup->behavior = DEVCG_DEFAULT_NONE; > > > - parent_cgroup = cgroup->parent; > > > > > > return &dev_cgroup->css; > > > } > > > > oops > > > > ACK > > Not seeing the patches this is based on in Linus' tree yet, but given > the context above I don't see how it could not be right :) they're on Tejun's tree -- Aristeu