Linux Container Development
 help / color / mirror / Atom feed
From: Artem Fetishev <artem_fetishev-uRwfk40T5oI@public.gmane.org>
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	alexandr_terekhov-uRwfk40T5oI@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org
Subject: [PATCH] proc: #68991 Fix GPF in /proc/$PID/map_files
Date: Sat, 8 Mar 2014 05:20:33 +0300	[thread overview]
Message-ID: <20140308022033.GC5690@owamsq.epam.com> (raw)

https://bugzilla.kernel.org/show_bug.cgi?id=68991

The expected logic of proc_map_files_get_link() is either to return 0 and
initialize 'path' or return an error and leave 'path' uninitialized. By the time
dname_to_vma_addr() returns 0 the corresponding vma may have already be gone. In
this case the path is not initialized but the return value is still 0. This
results in 'general protection fault' inside d_path().

Steps to reproduce:
CONFIG_CHECKPOINT_RESTORE=y

fd = open(...);
while (1) {
	mmap(fd, ...);
	munmap(fd, ...);
}

ls -la /proc/$PID/map_files

Signed-off-by: Artem Fetishev <artem_fetishev-uRwfk40T5oI@public.gmane.org>
Signed-off-by: Aleksandr Terekhov <aleksandr_terekhov-uRwfk40T5oI@public.gmane.org>
---
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 5150706..b976062 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1824,6 +1824,7 @@ static int proc_map_files_get_link(struct dentry *dentry, struct path *path)
 	if (rc)
 		goto out_mmput;
 
+	rc = -ENOENT;
 	down_read(&mm->mmap_sem);
 	vma = find_exact_vma(mm, vm_start, vm_end);
 	if (vma && vma->vm_file) {

             reply	other threads:[~2014-03-08  2:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-08  2:20 Artem Fetishev [this message]
     [not found] ` <20140308022033.GC5690-z1oL5kbKe2PzvzwRvDUw0Q@public.gmane.org>
2014-03-07 14:29   ` [PATCH] proc: #68991 Fix GPF in /proc/$PID/map_files Pavel Emelyanov
     [not found]     ` <5319D7B9.6050000-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2014-03-07 14:45       ` Cyrill Gorcunov
2014-03-07 20:17   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140308022033.GC5690@owamsq.epam.com \
    --to=artem_fetishev-urwfk40t5oi@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=alexandr_terekhov-uRwfk40T5oI@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox