From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [GIT PULL] cgroup changes for v3.15-rc1 Date: Fri, 4 Apr 2014 08:03:59 -0400 Message-ID: <20140404120359.GA5461@mtj.dyndns.org> References: <20140403164911.GE24119@htj.dyndns.org> <20140403194335.GC2472@mtj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Linus Torvalds Cc: Linux Containers , Linux Kernel Mailing List , "Eric W. Biederman" , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Miller List-Id: containers.vger.kernel.org On Thu, Apr 03, 2014 at 01:02:45PM -0700, Linus Torvalds wrote: > > The cgroup_root should be destroyed but it isn't, I think. We'd need > > to bump cgroup_root's refcnt only when a new sb is created. It's > > kinda ugly. Hmmm... > > Ok, so I guess we can use that "new_sb_created" thing, and I'll redo > my merge resolution to reflect that. I do find this incredibly ugly. I apparently missed the issue and designed the interface without considering this ugliness. Maybe kernfs could be made to wrap rather than providing mount/kill_sb() functions and hide details about sb or we can simply add fstype->umount() so that there's symmetry; however, the problem is kernfs-specific and other kernfs users would have single static backing store and won't need to care about this, so, for now, I think what it's a ugly but acceptable compromise. Thanks. -- tejun