From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serge Hallyn Subject: Re: [RESEND][PATCH] userns: use marco instead of magic number for max userns level Date: Thu, 11 Sep 2014 16:30:48 +0000 Message-ID: <20140911163048.GF24386@ubuntumail> References: <1410429091-7234-1-git-send-email-chenhanxiao@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1410429091-7234-1-git-send-email-chenhanxiao-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Chen Hanxiao Cc: Fabian Frederick , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Oleg Nesterov , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Eric W. Biederman" List-Id: containers.vger.kernel.org Quoting Chen Hanxiao (chenhanxiao-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org): > Use marco instead of magic number > for max user namespace level. > > Signed-off-by: Chen Hanxiao Acked-by: Serge E. Hallyn > --- > kernel/user_namespace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c > index aa312b0..5435489 100644 > --- a/kernel/user_namespace.c > +++ b/kernel/user_namespace.c > @@ -47,6 +47,8 @@ static void set_cred_user_ns(struct cred *cred, struct user_namespace *user_ns) > cred->user_ns = user_ns; > } > > +#define MAX_USER_NS_LEVEL 32 > + > /* > * Create a new user namespace, deriving the creator from the user in the > * passed credentials, and replacing that user with the new root user for the > @@ -62,7 +64,7 @@ int create_user_ns(struct cred *new) > kgid_t group = new->egid; > int ret; > > - if (parent_ns->level > 32) > + if (parent_ns->level > MAX_USER_NS_LEVEL) > return -EUSERS; > > /* > -- > 1.9.0 > > _______________________________________________ > Containers mailing list > Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linuxfoundation.org/mailman/listinfo/containers