Re: [PATCH v2 seccomp 2/6] asm/syscall.h: Add syscall_arches[] array

Al Viro
2020-09-25T00:18:33Z

On Fri, Sep 25, 2020 at 02:15:50AM +0200, Jann Horn wrote:
> On Fri, Sep 25, 2020 at 2:01 AM Kees Cook <keescook@chromium.org> wrote:
> > 2) seccomp needs to handle "multiplexed" tables like x86_x32 (distros
> > haven't removed CONFIG_X86_X32 widely yet, so it is a reality that
> > it must be dealt with), which means seccomp's idea of the arch
> > "number" can't be the same as the AUDIT_ARCH.
>
> Sure, distros ship it; but basically nobody uses it, it doesn't have
> to be fast. As long as we don't *break* it, everything's fine. And if
> we ignore the existence of X32 in the fastpath, that'll just mean that
> syscalls with the X32 marker bit always hit the seccomp slowpath
> (because it'll look like the syscall number is out-of-bounds ) - no
> problem.

You do realize that X32 is amd64 counterpart of mips n32, right? And that's
not "basically nobody uses it"...