From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77240C433E0 for ; Wed, 3 Mar 2021 07:01:24 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD51C64EE4 for ; Wed, 3 Mar 2021 07:01:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD51C64EE4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=containers-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3BB63400A8; Wed, 3 Mar 2021 07:01:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZLzAXK6fIssh; Wed, 3 Mar 2021 07:01:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTP id 5A1004002B; Wed, 3 Mar 2021 07:01:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3BC42C000B; Wed, 3 Mar 2021 07:01:22 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3B159C0001 for ; Wed, 3 Mar 2021 07:01:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1391F84399 for ; Wed, 3 Mar 2021 07:01:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BvgmlMwpFNiY for ; Wed, 3 Mar 2021 07:01:19 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.osuosl.org (Postfix) with ESMTPS id EDB1D8438E for ; Wed, 3 Mar 2021 07:01:18 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 16AAD68CFC; Wed, 3 Mar 2021 08:01:06 +0100 (CET) Date: Wed, 3 Mar 2021 08:01:03 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Subject: Re: [PATCH v6 39/40] xfs: support idmapped mounts Message-ID: <20210303070103.GA7866@lst.de> References: <20210121131959.646623-1-christian.brauner@ubuntu.com> <20210121131959.646623-40-christian.brauner@ubuntu.com> <20210301200520.GK7272@magnolia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210301200520.GK7272@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Lennart Poettering , Mimi Zohar , James Bottomley , Andreas Dilger , containers@lists.linux-foundation.org, Christoph Hellwig , Tycho Andersen , Paul Moore , Jonathan Corbet , smbarber@chromium.org, linux-ext4@vger.kernel.org, Mrunal Patel , Kees Cook , Arnd Bergmann , selinux@vger.kernel.org, Josh Triplett , linux-fsdevel@vger.kernel.org, Aleksa Sarai , Alexander Viro , Andy Lutomirski , OGAWA Hirofumi , Geoffrey Thomas , David Howells , John Johansen , Theodore Tso , Seth Forshee , Dmitry Kasatkin , Stephen Smalley , linux-xfs@vger.kernel.org, linux-security-module@vger.kernel.org, "Eric W. Biederman" , linux-api@vger.kernel.org, Casey Schaufler , Alban Crequy , linux-integrity@vger.kernel.org, Linus Torvalds , Todd Kjos X-BeenThere: containers@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux Containers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: containers-bounces@lists.linux-foundation.org Sender: "Containers" On Mon, Mar 01, 2021 at 12:05:20PM -0800, Darrick J. Wong wrote: > > + if (breq->mnt_userns != &init_user_ns) { > > + xfs_warn_ratelimited(breq->mp, > > + "bulkstat not supported inside of idmapped mounts."); > > + return -EINVAL; > > Shouldn't this be -EPERM? > > Or -EOPNOTSUPP? -EINVAL is what we return for all our nor suppored ioctls, so I think it is the right choice here, and should generally trigger the right fallbacks. > Also, I'm not sure why bulkstat won't work in an idmapped mount but > bulkstat_single does? You can use the singleton version to stat inodes > that aren't inside the submount. Looking at it again I think we should fail BULKSTAT_SINGLE as well. I had somehow assumed BULKSTAT_SINGLE would operate on the inode of the open file, in which case it would be fine. But it doesn't so that argument doesn't count. _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/containers