Re: [PATCH v8 07/19] ima: Move dentry into ima_namespace and others onto stack

Mimi Zohar
2022-01-13T20:28:21Z

Hi Stefan,

Nobody refers to the IMA securityfs files as dentries. The Subject
line is suppose to provide a hint about the patch. How about changing
the "Subject" line to "ima: Move IMA securityfs files into
ima_namespaces or onto stack".

On Tue, 2022-01-04 at 12:04 -0500, Stefan Berger wrote:
> From: Stefan Berger <stefanb@linux.ibm.com>
>
> Move the policy file dentry into the ima_namespace for reuse by
> virtualized SecurityFS and for being able to remove it from
> the filesystem. Move the other dentries onto the stack.

Missing is an explanation why the other IMA securityfs files can be on
the stack. Maybe start out by saying that the ns_ima_init securityfs
files are never deleted. Then transition into the IMA namespaced
securityfs files and how they will be deleted.

>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
> security/integrity/ima/ima.h | 2 ++
> security/integrity/ima/ima_fs.c | 32 ++++++++++++++++++--------------
> 2 files changed, 20 insertions(+), 14 deletions(-)
>
> diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h
> index 82b3f6a98320..224b09617c52 100644
> --- a/security/integrity/ima/ima.h
> +++ b/security/integrity/ima/ima.h
> @@ -140,6 +140,8 @@ struct ima_namespace {
> struct mutex ima_write_mutex;
> unsigned long ima_fs_flags;
> int valid_policy;
> +
> + struct dentry *policy_dentry;

None of the other securityfs files are renamed. Why is "ima_policy"
being renamed to "policy_dentry"? If there is a need, it should be
documented in the patch description.

thanks,

Mimi

> } __randomize_layout;
> extern struct ima_namespace init_ima_ns;
>