Linux Container Development
 help / color / mirror / Atom feed
From: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
To: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [RFC][patch 0/1] fix allnoconfig for net-2.6.24
Date: Wed, 12 Sep 2007 21:37:44 +0200	[thread overview]
Message-ID: <46E84008.1000001@fr.ibm.com> (raw)
In-Reply-To: <m1hclz93rg.fsf-T1Yj925okcoyDheHMi7gv2pdwda3JcWeAL8bYrjMMd8@public.gmane.org>

Eric W. Biederman wrote:
> dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org writes:
> 
>> The kernel compilation fails with allnoconfig with an unresolved to init_net.
>> I tryed to figure out how to fix that. The problem is raised because the
>> init_net
>> variable is defined as extern in net_namespace.h while the variable is declared
>> in net_namespace.c. This file is not compiled because of the config options and
>> that leads to the compilation error.
> 
> Ok.  We seem to have the same issue with the ipc namespace.
> And it uses the INIT_IPC_NS macro to handle it.
> 
> I wonder if we can do something similar here.
> 
> It looks like the initialization of nsproxy is the big gotcha.
> 
>> I noticed the uts namespace defines the init_uts_ns in init/version.c, so I
>> moved
>> the init_net to this file too. The compilation error is fixed.
>>
>> But I don't like really this approach because:
>> 	1 - we fall under a part not covered by the network
>> 	2 - we add a new include net_namespace.h in version.c
>>
>> Does this fix seems correct ? I just want to fix it for now to have net-2.6.24
>> compiling for all configs.
> 
> I think we can probably spend a couple more hours and fix things cleanly.
> If that we can't figure out a clean solution I'm happy to deal with the
> hack.  But if we can find something clean and maintainable I would
> very much prefer that.
> 
> So do you think you can come up with something based on the model
> of INIT_IPC_NS?

Sure, I will send it in a few hours ...

  parent reply	other threads:[~2007-09-12 19:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 17:07 [RFC][patch 0/1] fix allnoconfig for net-2.6.24 dlezcano-NmTC/0ZBporQT0dZR+AlfA
2007-09-12 17:07 ` [RFC][patch 1/1] From: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org> dlezcano-NmTC/0ZBporQT0dZR+AlfA
     [not found] ` <20070912170739.187625566-WECHFHqYCmGD/CxQmPlnQ0FT0OZdM7KVQQ4Iyu8u01E@public.gmane.org>
2007-09-12 17:23   ` [RFC][patch 0/1] fix allnoconfig for net-2.6.24 Eric W. Biederman
2007-09-12 17:45   ` Eric W. Biederman
     [not found]     ` <m1hclz93rg.fsf-T1Yj925okcoyDheHMi7gv2pdwda3JcWeAL8bYrjMMd8@public.gmane.org>
2007-09-12 19:37       ` Daniel Lezcano [this message]
     [not found]         ` <46E84008.1000001-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-09-12 19:45           ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E84008.1000001@fr.ibm.com \
    --to=dlezcano-nmtc/0zbporqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox