From: Cedric Le Goater <clg@fr.ibm.com>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Containers <containers@lists.osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use KMEM_CACHE macro to create the nsproxy cache
Date: Wed, 26 Sep 2007 15:37:35 +0200 [thread overview]
Message-ID: <46FA609F.60702@fr.ibm.com> (raw)
In-Reply-To: <46FA5D0F.2090604@openvz.org>
Pavel Emelyanov wrote:
> The blessed way for standard caches is to use it.
> Besides, this may give this cache a better alignment.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
yes of course. thanks.
Acked-by: Cedric Le Goater <clg@fr.ibm.com>
> ---
>
> diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
> index ee68964..31351cc 100644
> --- a/kernel/nsproxy.c
> +++ b/kernel/nsproxy.c
> @@ -222,8 +222,7 @@ void exit_task_namespaces(struct task_st
>
> static int __init nsproxy_cache_init(void)
> {
> - nsproxy_cachep = kmem_cache_create("nsproxy", sizeof(struct nsproxy),
> - 0, SLAB_PANIC, NULL);
> + nsproxy_cachep = KMEM_CACHE(nsproxy, SLAB_PANIC);
> return 0;
> }
>
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
>
next prev parent reply other threads:[~2007-09-26 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 13:22 [PATCH] Use KMEM_CACHE macro to create the nsproxy cache Pavel Emelyanov
2007-09-26 13:37 ` Cedric Le Goater [this message]
[not found] ` <46FA5D0F.2090604-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2007-09-26 13:39 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FA609F.60702@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=akpm@osdl.org \
--cc=containers@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox